chore: bridge-api fetchBridgeQuotes util #28027

micaelae · 2024-10-22T22:41:24Z

Description

Changes

Implement the fetchBridgeQuotes util to be used for making requests to the bridge-api getQuotes endpoint
Copy in bridge-api types
Create test data

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1448

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-10-22T23:32:35Z

Builds ready [7227ebf]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1901 ± 118 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	301	2687	1767	492	236
		domContentLoaded	1648	2679	1873	243	117
		load	1666	2689	1901	245	118
		domInteractive	19	213	67	55	26
		backgroundConnect	8	90	28	22	11
		firstReactRender	44	204	92	36	17
		getState	5	57	20	21	10
		initialActions	0	0	0	0	0
		loadScripts	1188	2164	1397	225	108
		setupStore	11	72	33	24	11
		uiStartup	1848	2885	2115	262	126

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.21 KiB (0.05%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/data/bridge/mock-quotes-erc20-erc20.ts

metamaskbot · 2024-10-23T23:05:52Z

Builds ready [0691f81]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1906 ± 114 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	218	2697	1814	438	210
		domContentLoaded	1664	2654	1878	235	113
		load	1673	2689	1906	238	114
		domInteractive	26	142	50	26	13
		backgroundConnect	7	73	29	21	10
		firstReactRender	46	215	98	44	21
		getState	4	52	12	14	7
		initialActions	0	1	0	0	0
		loadScripts	1123	1744	1359	154	74
		setupStore	11	89	36	26	12
		uiStartup	1875	2923	2129	253	121

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.21 KiB (0.05%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

ui/pages/bridge/bridge.util.ts

ui/pages/bridge/types.ts

metamaskbot · 2024-10-28T18:48:09Z

Builds ready [2961691]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1887 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	529	2063	1788	300	144
		domContentLoaded	1685	2375	1853	145	69
		load	1720	2426	1887	150	72
		domInteractive	17	148	52	34	16
		backgroundConnect	8	70	36	21	10
		firstReactRender	48	115	92	22	10
		getState	4	58	13	15	7
		initialActions	0	1	0	0	0
		loadScripts	1234	1945	1384	148	71
		setupStore	11	68	25	20	10
		uiStartup	1925	2594	2079	147	71

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 3.87 KiB (0.09%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-10-28T20:12:58Z

Builds ready [27299ad]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1932 ± 57 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	448	2179	1782	446	214
		domContentLoaded	1679	2164	1904	113	54
		load	1693	2183	1932	119	57
		domInteractive	22	85	48	17	8
		backgroundConnect	9	80	30	23	11
		firstReactRender	52	296	109	46	22
		getState	5	61	23	22	10
		initialActions	0	1	0	0	0
		loadScripts	1206	1620	1406	99	48
		setupStore	11	99	32	27	13
		uiStartup	1897	2675	2181	176	84

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 3.87 KiB (0.09%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

github-actions bot added the team-bridge label Oct 22, 2024

micaelae marked this pull request as ready for review October 22, 2024 23:21

micaelae requested a review from a team as a code owner October 22, 2024 23:21

micaelae requested a review from a team October 23, 2024 01:03

ejwessel previously approved these changes Oct 23, 2024

View reviewed changes

test/data/bridge/mock-quotes-erc20-erc20.ts Outdated Show resolved Hide resolved

micaelae dismissed ejwessel’s stale review via 0691f81 October 23, 2024 22:33

micaelae force-pushed the mb891-1-fetch-quotes-util branch from 7227ebf to 0691f81 Compare October 23, 2024 22:33

ejwessel previously approved these changes Oct 23, 2024

View reviewed changes

micaelae requested a review from a team October 23, 2024 23:27

infiniteflower reviewed Oct 25, 2024

View reviewed changes

ui/pages/bridge/bridge.util.ts Outdated Show resolved Hide resolved

ui/pages/bridge/bridge.util.ts Outdated Show resolved Hide resolved

ui/pages/bridge/types.ts Outdated Show resolved Hide resolved

micaelae dismissed ejwessel’s stale review via 2961691 October 28, 2024 18:13

micaelae force-pushed the mb891-1-fetch-quotes-util branch from 0691f81 to 2961691 Compare October 28, 2024 18:13

infiniteflower self-requested a review October 28, 2024 19:33

infiniteflower approved these changes Oct 28, 2024

View reviewed changes

micaelae added 8 commits October 28, 2024 12:38

chore: bridge types

10f77cf

chore: add bridge-api fetchBridgeQuotes util

6ee0b8c

fix: types

50616f4

chore: save test data as json

e77cbf2

chore: move quote req validator to util file

97493a6

fix: use URLSearchParams

29db910

chore: move bridge-api response validators to a separate file

8f87370

chore: use nested validators for readability

27299ad

micaelae force-pushed the mb891-1-fetch-quotes-util branch from 2961691 to 27299ad Compare October 28, 2024 19:38

ejwessel approved these changes Oct 28, 2024

View reviewed changes

micaelae added this pull request to the merge queue Oct 28, 2024

Merged via the queue into develop with commit 6343b34 Oct 28, 2024
76 checks passed

micaelae deleted the mb891-1-fetch-quotes-util branch October 28, 2024 20:36

github-actions bot locked and limited conversation to collaborators Oct 28, 2024

metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bridge-api fetchBridgeQuotes util #28027

chore: bridge-api fetchBridgeQuotes util #28027

micaelae commented Oct 22, 2024 •

edited

Loading

metamaskbot commented Oct 22, 2024

metamaskbot commented Oct 23, 2024

metamaskbot commented Oct 28, 2024

metamaskbot commented Oct 28, 2024

chore: bridge-api fetchBridgeQuotes util #28027

chore: bridge-api fetchBridgeQuotes util #28027

Conversation

micaelae commented Oct 22, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Oct 22, 2024

metamaskbot commented Oct 23, 2024

metamaskbot commented Oct 28, 2024

metamaskbot commented Oct 28, 2024

micaelae commented Oct 22, 2024 •

edited

Loading