-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update bridge quote request on input change #28028
Merged
Merged
+336
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micaelae
force-pushed
the
mb891-2-quote-request-params
branch
from
October 22, 2024 23:22
9aa4724
to
6d20c11
Compare
Builds ready [6d20c11]
Page Load Metrics (1984 ± 117 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ejwessel
approved these changes
Oct 23, 2024
micaelae
force-pushed
the
mb891-1-fetch-quotes-util
branch
from
October 23, 2024 22:33
7227ebf
to
0691f81
Compare
micaelae
force-pushed
the
mb891-2-quote-request-params
branch
from
October 23, 2024 22:37
6d20c11
to
afc17f6
Compare
ejwessel
previously approved these changes
Oct 23, 2024
Builds ready [afc17f6]
Page Load Metrics (2065 ± 158 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
force-pushed
the
mb891-1-fetch-quotes-util
branch
2 times, most recently
from
October 28, 2024 19:38
2961691
to
27299ad
Compare
micaelae
force-pushed
the
mb891-2-quote-request-params
branch
from
October 28, 2024 20:37
afc17f6
to
1a52f74
Compare
Builds ready [1a52f74]
Page Load Metrics (2044 ± 101 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
infiniteflower
approved these changes
Oct 29, 2024
ejwessel
approved these changes
Oct 29, 2024
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
quoteRequest
state value in BridgeController to track active quoteRequest objectRelated issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1448
Manual testing steps
Screenshots/Recordings
Before
N/A
After
Screen.Recording.2024-10-21.at.4.39.47.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist