Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update bridge quote request on input change #28028

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Oct 22, 2024

Description

Changes

  • Added quoteRequest state value in BridgeController to track active quoteRequest object
  • Read quote refresh rate from bridge feature flag

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1448

Manual testing steps

  1. Request bridge quotes
  2. Click "Switch" button and verify that new quotes with updated params are requested/shown
  3. Verify that bridge parameters are reset when extension is reopened
  4. Check that state is updated

Screenshots/Recordings

Before

N/A

After

Screen.Recording.2024-10-21.at.4.39.47.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae changed the base branch from develop to mb891-1-fetch-quotes-util October 22, 2024 22:42
@metamaskbot
Copy link
Collaborator

Builds ready [6d20c11]
Page Load Metrics (1984 ± 117 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint166025791984258124
domContentLoaded165023881946228110
load166024761984244117
domInteractive16162553818
backgroundConnect8101373416
firstReactRender452871005627
getState471172010
initialActions00000
loadScripts117419211430208100
setupStore1394412311
uiStartup186528942239305146
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.6 KiB (0.08%)
  • ui: 1.2 KiB (0.02%)
  • common: 241 Bytes (0.00%)

@micaelae micaelae marked this pull request as ready for review October 23, 2024 00:02
@micaelae micaelae requested a review from a team as a code owner October 23, 2024 00:02
@micaelae micaelae changed the base branch from mb891-1-fetch-quotes-util to develop October 23, 2024 00:18
@micaelae micaelae changed the base branch from develop to mb891-1-fetch-quotes-util October 23, 2024 00:18
ui/ducks/bridge/selectors.ts Outdated Show resolved Hide resolved
ejwessel
ejwessel previously approved these changes Oct 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [afc17f6]
Page Load Metrics (2065 ± 158 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28633081989509245
domContentLoaded179032912029337162
load181332952065330158
domInteractive18178544120
backgroundConnect887382713
firstReactRender532961256632
getState4461194
initialActions01000
loadScripts128327691532328157
setupStore1294412814
uiStartup203735362321329158
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.6 KiB (0.08%)
  • ui: 1.2 KiB (0.02%)
  • common: 241 Bytes (0.00%)

ui/ducks/bridge/actions.ts Outdated Show resolved Hide resolved
ui/pages/bridge/bridge.util.ts Outdated Show resolved Hide resolved
ui/pages/bridge/prepare/prepare-bridge-page.tsx Outdated Show resolved Hide resolved
@micaelae micaelae force-pushed the mb891-1-fetch-quotes-util branch 2 times, most recently from 2961691 to 27299ad Compare October 28, 2024 19:38
Base automatically changed from mb891-1-fetch-quotes-util to develop October 28, 2024 20:36
@micaelae micaelae dismissed ejwessel’s stale review October 28, 2024 20:36

The base branch was changed.

@metamaskbot
Copy link
Collaborator

Builds ready [1a52f74]
Page Load Metrics (2044 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37526241864536257
domContentLoaded17942547201120498
load181626052044209101
domInteractive21121512512
backgroundConnect870362110
firstReactRender492001063115
getState562232211
initialActions01000
loadScripts13341929149816479
setupStore1367312110
uiStartup200828352269237114
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.34 KiB (0.03%)
  • ui: 1.17 KiB (0.02%)
  • common: 241 Bytes (0.00%)

@micaelae micaelae added this pull request to the merge queue Oct 29, 2024
Merged via the queue into develop with commit 7df5cef Oct 29, 2024
76 checks passed
@micaelae micaelae deleted the mb891-2-quote-request-params branch October 29, 2024 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants