chore: poll for bridge quotes #28029

micaelae · 2024-10-22T22:45:00Z

Description

Changes:

Import the polling controller package and update lavamoat
Modify the BridgeController to extend the StaticIntervalPollingController. This is needed for polling bridge-api quotes once a valid quote request has been entered by a user

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1448

Manual testing steps

Set BRIDGE_USE_DEV_APIS=1 in .metamaskrc
Open background network tab
Request bridge quotes in the extension
Verify that a getQuote network request is made with the specified parameters

Screenshots/Recordings

Before

N/A

After

Screen.Recording.2024-10-21.at.4.39.47.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-10-23T01:15:00Z

Builds ready [9f1f4a4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2275 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	434	2894	2180	452	217
		domContentLoaded	1892	2823	2239	208	100
		load	1942	2881	2275	209	100
		domInteractive	18	198	58	36	17
		backgroundConnect	8	82	33	26	13
		firstReactRender	64	325	140	64	31
		getState	6	92	35	28	13
		initialActions	0	1	0	0	0
		loadScripts	1316	1906	1637	151	73
		setupStore	12	85	32	25	12
		uiStartup	2189	3264	2573	283	136

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 20.39 KiB (0.46%)
ui: 1.2 KiB (0.02%)
common: -121 Bytes (-0.00%)

metamaskbot · 2024-10-23T01:17:28Z

Builds ready [9f1f4a4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2275 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	434	2894	2180	452	217
		domContentLoaded	1892	2823	2239	208	100
		load	1942	2881	2275	209	100
		domInteractive	18	198	58	36	17
		backgroundConnect	8	82	33	26	13
		firstReactRender	64	325	140	64	31
		getState	6	92	35	28	13
		initialActions	0	1	0	0	0
		loadScripts	1316	1906	1637	151	73
		setupStore	12	85	32	25	12
		uiStartup	2189	3264	2573	283	136

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 20.39 KiB (0.46%)
ui: 1.2 KiB (0.02%)
common: -121 Bytes (-0.00%)

metamaskbot · 2024-10-23T23:23:42Z

Builds ready [dc7a5d2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1979 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	359	2173	1916	372	178
		domContentLoaded	1752	2116	1944	101	48
		load	1761	2176	1979	109	52
		domInteractive	20	78	46	18	8
		backgroundConnect	8	100	28	25	12
		firstReactRender	55	215	117	42	20
		getState	6	63	26	21	10
		initialActions	0	1	0	0	0
		loadScripts	1316	1590	1451	87	42
		setupStore	11	75	30	22	11
		uiStartup	1976	2750	2237	161	77

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 20.39 KiB (0.47%)
ui: 1.2 KiB (0.02%)
common: -121 Bytes (-0.00%)

infiniteflower · 2024-10-25T18:41:29Z

app/scripts/controllers/bridge/types.ts

  BridgeControllerEvents,
-  never,
+  AccountsControllerGetSelectedAccountAction['type'],


I suggest the following for readability purposes

type AllowedActions = AccountsControllerGetSelectedAccountAction['type'] type AllowedEvents = never export type BridgeControllerMessenger = RestrictedControllerMessenger< typeof BRIDGE_CONTROLLER_NAME, BridgeControllerActions | AccountsControllerGetSelectedAccountAction, BridgeControllerEvents, AllowedActions, AllowedEvents >

The base branch was changed.

metamaskbot · 2024-10-28T21:29:11Z

Builds ready [9c78fb2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2095 ± 98 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	284	2194	1880	530	254
		domContentLoaded	1843	2899	2074	207	100
		load	1855	2907	2095	205	98
		domInteractive	16	91	52	18	9
		backgroundConnect	7	65	20	17	8
		firstReactRender	55	169	112	22	10
		getState	5	67	26	24	12
		initialActions	0	1	0	0	0
		loadScripts	1326	2155	1506	170	82
		setupStore	13	72	31	25	12
		uiStartup	2098	3207	2328	219	105

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 18.66 KiB (0.42%)
ui: 1.17 KiB (0.02%)
common: -121 Bytes (-0.00%)

The base branch was changed.

metamaskbot · 2024-10-29T23:04:39Z

Builds ready [bf5166a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1983 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	289	2412	1831	540	259
		domContentLoaded	1750	2355	1950	162	78
		load	1784	2412	1983	166	80
		domInteractive	19	83	50	16	7
		backgroundConnect	7	116	34	30	14
		firstReactRender	58	175	100	26	13
		getState	5	60	30	21	10
		initialActions	0	0	0	0	0
		loadScripts	1258	1808	1431	133	64
		setupStore	12	75	27	20	10
		uiStartup	2002	2663	2204	182	87

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 25.45 KiB (0.57%)
ui: 0 Bytes (0.00%)
common: 468 Bytes (0.01%)

github-actions bot added the team-bridge label Oct 22, 2024

micaelae changed the base branch from develop to mb891-2-quote-request-params October 22, 2024 22:45

micaelae force-pushed the mb891-2-quote-request-params branch from 9aa4724 to 6d20c11 Compare October 22, 2024 23:22

micaelae force-pushed the mb891-3-quote-polling branch from 2761d03 to 778d550 Compare October 23, 2024 00:17

micaelae marked this pull request as ready for review October 23, 2024 00:21

micaelae requested review from a team as code owners October 23, 2024 00:21

micaelae force-pushed the mb891-3-quote-polling branch from 778d550 to 9f1f4a4 Compare October 23, 2024 00:38

ejwessel previously approved these changes Oct 23, 2024

View reviewed changes

micaelae force-pushed the mb891-2-quote-request-params branch from 6d20c11 to afc17f6 Compare October 23, 2024 22:37

micaelae requested review from a team October 23, 2024 22:40

micaelae force-pushed the mb891-3-quote-polling branch from 9f1f4a4 to dc7a5d2 Compare October 23, 2024 22:46

infiniteflower reviewed Oct 25, 2024

View reviewed changes

micaelae force-pushed the mb891-2-quote-request-params branch from afc17f6 to 1a52f74 Compare October 28, 2024 20:37

micaelae force-pushed the mb891-3-quote-polling branch from dc7a5d2 to 8498fe7 Compare October 28, 2024 20:39

micaelae changed the base branch from mb891-2-quote-request-params to develop October 28, 2024 20:40

micaelae changed the base branch from develop to mb891-2-quote-request-params October 28, 2024 20:40

micaelae force-pushed the mb891-3-quote-polling branch from 8498fe7 to 9c78fb2 Compare October 28, 2024 20:54

infiniteflower previously approved these changes Oct 29, 2024

View reviewed changes

ejwessel previously approved these changes Oct 29, 2024

View reviewed changes

Base automatically changed from mb891-2-quote-request-params to develop October 29, 2024 21:09

micaelae force-pushed the mb891-3-quote-polling branch from 9c78fb2 to 920ece8 Compare October 29, 2024 21:58

micaelae force-pushed the mb891-3-quote-polling branch from 920ece8 to a5a28dd Compare October 29, 2024 22:01

micaelae added 2 commits October 29, 2024 15:20

feat: poll for bridge quotes

e3ba9bd

chore: bridge controller types readability

bf5166a

micaelae force-pushed the mb891-3-quote-polling branch from a5a28dd to bf5166a Compare October 29, 2024 22:20

infiniteflower approved these changes Oct 29, 2024

View reviewed changes

ejwessel approved these changes Oct 29, 2024

View reviewed changes

micaelae added this pull request to the merge queue Oct 30, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024

micaelae added this pull request to the merge queue Oct 30, 2024

Merged via the queue into develop with commit 7e765c3 Oct 30, 2024
76 checks passed

micaelae deleted the mb891-3-quote-polling branch October 30, 2024 15:06

github-actions bot locked and limited conversation to collaborators Oct 30, 2024

metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: poll for bridge quotes #28029

chore: poll for bridge quotes #28029

micaelae commented Oct 22, 2024 •

edited

Loading

metamaskbot commented Oct 23, 2024

metamaskbot commented Oct 23, 2024

metamaskbot commented Oct 23, 2024

infiniteflower Oct 25, 2024

metamaskbot commented Oct 28, 2024

metamaskbot commented Oct 29, 2024

chore: poll for bridge quotes #28029

chore: poll for bridge quotes #28029

Conversation

micaelae commented Oct 22, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Oct 23, 2024

metamaskbot commented Oct 23, 2024

metamaskbot commented Oct 23, 2024

infiniteflower Oct 25, 2024

Choose a reason for hiding this comment

metamaskbot commented Oct 28, 2024

metamaskbot commented Oct 29, 2024

micaelae commented Oct 22, 2024 •

edited

Loading