chore: display bridge quotes #28031

micaelae · 2024-10-23T00:28:47Z

Description

Changes:

display recommended quote in BridgeQuoteCard
add a placeholder modal for displaying alternative quotes

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1448

Manual testing steps

Request bridge quotes
Click "Switch" button and verify that new quotes with updated params are requested/shown
Verify that bridge parameters are reset when extension is reopened

Screenshots/Recordings

Before

N/A

After

Screen.Recording.2024-10-21.at.4.39.47.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-10-23T01:14:14Z

Builds ready [6dc9d16]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1770 ± 94 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	357	2079	1617	419	201
		domContentLoaded	1442	2268	1748	190	91
		load	1449	2283	1770	196	94
		domInteractive	15	166	55	38	18
		backgroundConnect	7	87	25	25	12
		firstReactRender	44	211	94	34	16
		getState	4	54	15	15	7
		initialActions	0	1	0	0	0
		loadScripts	1057	1802	1275	172	83
		setupStore	10	80	33	24	11
		uiStartup	1633	2458	1981	218	105

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 18.26 KiB (0.41%)
ui: 13.68 KiB (0.18%)
common: 2.76 KiB (0.03%)

ui/ducks/bridge/selectors.ts

ui/hooks/bridge/useCountdownTimer.ts

ui/pages/bridge/utils/quote.ts

ui/ducks/bridge/selectors.ts

ui/pages/bridge/quotes/bridge-quotes-modal.tsx

metamaskbot · 2024-10-28T21:44:45Z

Builds ready [106213c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1859 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1697	2263	1855	133	64
		domContentLoaded	1686	2241	1828	125	60
		load	1699	2269	1859	134	64
		domInteractive	16	68	40	15	7
		backgroundConnect	9	86	30	24	11
		firstReactRender	51	129	86	22	10
		getState	5	70	19	20	10
		initialActions	0	1	0	0	0
		loadScripts	1213	1674	1338	103	49
		setupStore	12	71	39	24	11
		uiStartup	1896	2531	2074	152	73

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 16.75 KiB (0.38%)
ui: 12.89 KiB (0.17%)
common: 3.14 KiB (0.04%)

metamaskbot · 2024-10-30T16:15:02Z

Builds ready [1637e81]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2515 ± 176 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	313	3821	1773	1088	523
		domContentLoaded	2035	3778	2481	368	177
		load	2086	3808	2515	367	176
		domInteractive	28	184	69	42	20
		backgroundConnect	9	79	34	21	10
		firstReactRender	65	223	123	33	16
		getState	8	73	29	21	10
		initialActions	0	1	0	0	0
		loadScripts	1565	3112	1875	332	159
		setupStore	13	95	40	25	12
		uiStartup	2326	4216	2811	409	196

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.92 KiB (-0.04%)
ui: 11.72 KiB (0.15%)
common: 3.26 KiB (0.04%)

metamaskbot · 2024-10-30T17:49:10Z

Builds ready [2bfa744]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1927 ± 105 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	310	2499	1783	511	245
		domContentLoaded	1664	2488	1902	221	106
		load	1674	2497	1927	219	105
		domInteractive	17	231	71	48	23
		backgroundConnect	9	86	30	23	11
		firstReactRender	53	198	107	38	18
		getState	4	62	17	19	9
		initialActions	0	1	0	0	0
		loadScripts	1211	1947	1410	196	94
		setupStore	10	74	30	23	11
		uiStartup	1876	2809	2165	254	122

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.92 KiB (-0.04%)
ui: 11.22 KiB (0.15%)
common: 3.26 KiB (0.04%)

metamaskbot · 2024-11-04T18:49:02Z

Builds ready [ca66c36]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2071 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	330	2378	1984	410	197
		domContentLoaded	1761	2332	2032	154	74
		load	1808	2385	2071	162	78
		domInteractive	19	89	53	19	9
		backgroundConnect	14	68	34	21	10
		firstReactRender	83	291	112	42	20
		getState	6	71	28	24	12
		initialActions	0	1	0	0	0
		loadScripts	1315	1817	1514	125	60
		setupStore	13	67	23	15	7
		uiStartup	1957	2642	2326	192	92

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.92 KiB (-0.04%)
ui: 11.22 KiB (0.15%)
common: 3.26 KiB (0.04%)

micaelae changed the base branch from develop to mb891-3-quote-polling October 23, 2024 00:28

github-actions bot added the team-bridge label Oct 23, 2024

micaelae marked this pull request as ready for review October 23, 2024 00:33

micaelae requested a review from a team as a code owner October 23, 2024 00:33

micaelae force-pushed the mb891-3-quote-polling branch from 778d550 to 9f1f4a4 Compare October 23, 2024 00:38

micaelae requested a review from a team as a code owner October 23, 2024 00:38

micaelae force-pushed the mb891-4-render-quotes branch from 7157be0 to 6dc9d16 Compare October 23, 2024 00:39

micaelae requested review from a team and removed request for a team October 23, 2024 00:41

ejwessel reviewed Oct 23, 2024

View reviewed changes

ui/ducks/bridge/selectors.ts Show resolved Hide resolved

ui/hooks/bridge/useCountdownTimer.ts Outdated Show resolved Hide resolved

ui/pages/bridge/utils/quote.ts Show resolved Hide resolved

micaelae force-pushed the mb891-3-quote-polling branch from 9f1f4a4 to dc7a5d2 Compare October 23, 2024 22:46

micaelae force-pushed the mb891-4-render-quotes branch from 6dc9d16 to afba192 Compare October 23, 2024 22:52

infiniteflower reviewed Oct 25, 2024

View reviewed changes

ui/ducks/bridge/selectors.ts Outdated Show resolved Hide resolved

ui/pages/bridge/quotes/bridge-quotes-modal.tsx Outdated Show resolved Hide resolved

micaelae force-pushed the mb891-3-quote-polling branch from dc7a5d2 to 8498fe7 Compare October 28, 2024 20:39

micaelae force-pushed the mb891-4-render-quotes branch from afba192 to 6f65ed2 Compare October 28, 2024 20:46

micaelae force-pushed the mb891-3-quote-polling branch from 8498fe7 to 9c78fb2 Compare October 28, 2024 20:54

micaelae force-pushed the mb891-4-render-quotes branch from 6f65ed2 to d0a5e08 Compare October 28, 2024 20:55

micaelae force-pushed the mb891-3-quote-polling branch 3 times, most recently from a5a28dd to bf5166a Compare October 29, 2024 22:20

micaelae force-pushed the mb891-4-render-quotes branch from 106213c to c732847 Compare October 30, 2024 00:04

Base automatically changed from mb891-3-quote-polling to develop October 30, 2024 15:06

micaelae force-pushed the mb891-4-render-quotes branch from c732847 to 1637e81 Compare October 30, 2024 15:36

micaelae force-pushed the mb891-4-render-quotes branch from a415449 to 2bfa744 Compare October 30, 2024 17:15

infiniteflower approved these changes Oct 30, 2024

View reviewed changes

micaelae enabled auto-merge October 30, 2024 19:38

micaelae added 8 commits November 4, 2024 09:41

chore: show recommended bridge quote

7d4fdec

feat: show all quotes in a modal

3509173

chore: display quote loading state

5866463

chore: replace hardcoded values with a constant

9ed2955

fix: test data import

d6d6eb7

chore: rm sort handler

b3d0083

fix: hide app header in Bridge page

71afb69

chore: rm toAmount formatting bc TextField handles that

ca66c36

micaelae force-pushed the mb891-4-render-quotes branch from 2bfa744 to ca66c36 Compare November 4, 2024 17:42

jclancy93 approved these changes Nov 5, 2024

View reviewed changes

micaelae added this pull request to the merge queue Nov 5, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024

micaelae added this pull request to the merge queue Nov 5, 2024

Merged via the queue into develop with commit 7b8d2c6 Nov 5, 2024
76 checks passed

micaelae deleted the mb891-4-render-quotes branch November 5, 2024 14:44

github-actions bot locked and limited conversation to collaborators Nov 5, 2024

metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: display bridge quotes #28031

chore: display bridge quotes #28031

micaelae commented Oct 23, 2024 •

edited

Loading

metamaskbot commented Oct 23, 2024

metamaskbot commented Oct 28, 2024

metamaskbot commented Oct 30, 2024

metamaskbot commented Oct 30, 2024

metamaskbot commented Nov 4, 2024

chore: display bridge quotes #28031

chore: display bridge quotes #28031

Conversation

micaelae commented Oct 23, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Oct 23, 2024

metamaskbot commented Oct 28, 2024

metamaskbot commented Oct 30, 2024

metamaskbot commented Oct 30, 2024

metamaskbot commented Nov 4, 2024

micaelae commented Oct 23, 2024 •

edited

Loading