-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add re-simulation logic #28104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team-confirmations
Push issues to confirmations team
label
Oct 25, 2024
OGPoyraz
commented
Oct 25, 2024
ui/pages/confirmations/hooks/alerts/transactions/useResimulationAlert.ts
Outdated
Show resolved
Hide resolved
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/base-controller@7.0.1 |
OGPoyraz
force-pushed
the
3380-simulation-retrigger
branch
from
October 29, 2024 15:28
ee81c0d
to
1713489
Compare
@metamaskbot update-policies |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
matthewwalsh0
previously approved these changes
Oct 29, 2024
sleepytanya
previously approved these changes
Oct 29, 2024
OGPoyraz
dismissed stale reviews from sleepytanya and matthewwalsh0
via
October 29, 2024 17:35
097d33b
Builds ready [097d33b]
Page Load Metrics (1862 ± 67 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sleepytanya
approved these changes
Oct 29, 2024
matthewwalsh0
approved these changes
Oct 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to add re-simulation logic which recently added at MetaMask/core#4792 Patch note: Transaction controller patch adds the re-simulate feature, branched belove to keep track. https://github.com/MetaMask/core/tree/patch/extension-transaction-controller-37-2-0 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28104?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#3380 ## **Manual testing steps** TBD ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** ![1](https://github.com/user-attachments/assets/67fc06d4-2f01-4e95-b1da-e84f5145462e) ![2](https://github.com/user-attachments/assets/52153a4a-4c0d-44bd-990b-51f9b90eefb4) ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 30, 2024
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.7.0
Issue or pull request that will be included in release 12.7.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add re-simulation logic which recently added at MetaMask/core#4792
Patch note:
Transaction controller patch adds the re-simulate feature, branched belove to keep track.
https://github.com/MetaMask/core/tree/patch/extension-transaction-controller-37-2-0
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3380
Manual testing steps
TBD
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist