Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add re-simulation logic #28104

Merged
merged 41 commits into from
Oct 30, 2024
Merged

feat: Add re-simulation logic #28104

merged 41 commits into from
Oct 30, 2024

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Oct 25, 2024

Description

This PR aims to add re-simulation logic which recently added at MetaMask/core#4792

Patch note:
Transaction controller patch adds the re-simulate feature, branched belove to keep track.
https://github.com/MetaMask/core/tree/patch/extension-transaction-controller-37-2-0

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3380

Manual testing steps

TBD

Screenshots/Recordings

Before

After

1
2

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested review from a team as code owners October 25, 2024 11:09
@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Oct 25, 2024
@OGPoyraz OGPoyraz changed the base branch from develop to Version-v12.5.1 October 25, 2024 11:46
@OGPoyraz OGPoyraz requested review from a team and kumavis as code owners October 25, 2024 11:46
@OGPoyraz OGPoyraz changed the base branch from Version-v12.5.1 to develop October 25, 2024 11:46
@OGPoyraz OGPoyraz removed request for a team and kumavis October 25, 2024 11:47
Copy link

socket-security bot commented Oct 29, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/base-controller@7.0.2 None +1 1.06 MB metamaskbot

🚮 Removed packages: npm/@metamask/base-controller@7.0.1

View full report↗︎

@OGPoyraz
Copy link
Member Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

matthewwalsh0
matthewwalsh0 previously approved these changes Oct 29, 2024
sleepytanya
sleepytanya previously approved these changes Oct 29, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [097d33b]
Page Load Metrics (1862 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16982236187114268
domContentLoaded16882176183613666
load16982239186213967
domInteractive17222514220
backgroundConnect106226199
firstReactRender492951035526
getState469202412
initialActions00000
loadScripts12121617134411053
setupStore1170262211
uiStartup18612587209219292
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.71 KiB (0.04%)
  • common: 106.22 KiB (1.34%)

@OGPoyraz OGPoyraz added this pull request to the merge queue Oct 30, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR aims to add re-simulation logic which recently added at
MetaMask/core#4792

Patch note: 
Transaction controller patch adds the re-simulate feature, branched
belove to keep track.

https://github.com/MetaMask/core/tree/patch/extension-transaction-controller-37-2-0

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28104?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3380

## **Manual testing steps**

TBD

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


![1](https://github.com/user-attachments/assets/67fc06d4-2f01-4e95-b1da-e84f5145462e)

![2](https://github.com/user-attachments/assets/52153a4a-4c0d-44bd-990b-51f9b90eefb4)


## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 30, 2024
@OGPoyraz OGPoyraz added this pull request to the merge queue Oct 30, 2024
Merged via the queue into develop with commit 2c86162 Oct 30, 2024
76 checks passed
@OGPoyraz OGPoyraz deleted the 3380-simulation-retrigger branch October 30, 2024 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants