Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds Solana snap to preinstall list #28141

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Oct 29, 2024

Description

Adds the Solana snap to the preinstall list.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-mmi PRs from the MMI team label Oct 29, 2024
@zone-live zone-live added team-sol PRs from the Solana snap team and removed team-mmi PRs from the MMI team labels Oct 29, 2024
Copy link

socket-security bot commented Nov 6, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/solana-wallet-snap@0.1.9 None +3 932 kB metamaskbot

View full report↗︎

@zone-live zone-live marked this pull request as ready for review November 7, 2024 10:02
@zone-live zone-live requested review from a team as code owners November 7, 2024 10:02
@zone-live zone-live changed the title chore: adds snap to prerelease list chore: adds Solana snap to prerelease list Nov 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [bfbb5a4]
Page Load Metrics (2107 ± 145 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint176728802103303145
domContentLoaded175428062074289139
load176628722107301145
domInteractive22288868239
backgroundConnect8113292412
firstReactRender81140105147
getState569232311
initialActions01000
loadScripts124022531516262126
setupStore1169322211
uiStartup197231082350334160
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live changed the title chore: adds Solana snap to prerelease list chore: adds Solana snap to preinstall list Nov 7, 2024
@zone-live zone-live added this pull request to the merge queue Nov 7, 2024
Merged via the queue into develop with commit 0064020 Nov 7, 2024
85 checks passed
@zone-live zone-live deleted the SOL-7-adds-snap-as-preinstall-in-config branch November 7, 2024 10:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-sol PRs from the Solana snap team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants