-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Permit message, dataTree value incorrectly using default ERC20 decimals for non-ERC20 token values #28142
Merged
+17
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
digiwand
changed the title
fix: Permit dataTree should not enforce ERC20 18 digit decimals if to…
fix: Permit message, dataTree value incorrectly using default ERC20 decimals for non-ERC20 token values
Oct 29, 2024
Builds ready [0239fa5]
Page Load Metrics (1960 ± 86 ms)
Bundle size diffs
|
pedronfigueiredo
previously approved these changes
Oct 30, 2024
Builds ready [876ae40]
Page Load Metrics (2215 ± 135 ms)
Bundle size diffs
|
matthewwalsh0
previously approved these changes
Nov 1, 2024
digiwand
dismissed stale reviews from matthewwalsh0 and pedronfigueiredo
via
November 4, 2024 15:17
0207051
Builds ready [0207051]
Page Load Metrics (1844 ± 100 ms)
Bundle size diffs
|
matthewwalsh0
approved these changes
Nov 5, 2024
pedronfigueiredo
approved these changes
Nov 5, 2024
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Nov 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.8.0
Issue or pull request that will be included in release 12.8.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes bug where fetchErc20Decimals was used in
ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign.tsx
info component and passed to the message dataTree to be used. fetchErc20Decimals was incorrectly used as it cannot be assumed that the token contract is an ERC20 standard. Fixed by calling useGetTokenStandardAndDetails instead which will use the default 18 decimals digit if the standard is an ERC20 token with no decimals found in the details.Related issues
Fixes: #28118
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist