feat: Capture 3 existing properties within non-anonymous transaction …

[pedronfigueiredo]

…events

Description

Moved properties simulations_sending_assets_total_value, simulations_receiving_assets_total_value and transaction_contract_method from sensitiveProperties to properties. They now show up in both Anon and non-Anon events.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3506

Manual testing steps

1. Build the app with a segment key to a personal test workspace.
2. Create a transaction with simulations
3. Check the debugger screen to inspect the events

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [935e0b0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1987 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1785	2418	1990	131	63
		domContentLoaded	1772	2405	1958	129	62
		load	1784	2421	1987	138	66
		domInteractive	24	78	56	16	8
		backgroundConnect	10	72	26	20	10
		firstReactRender	52	312	120	65	31
		getState	5	63	23	22	11
		initialActions	0	1	0	0	0
		loadScripts	1311	1827	1442	110	53
		setupStore	11	72	30	23	11
		uiStartup	2055	2841	2252	199	96

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 68 Bytes (0.00%)
• ui: -114 Bytes (-0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [44f2b60]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2007 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	549	2383	1941	352	169
		domContentLoaded	1751	2308	1971	137	66
		load	1806	2389	2007	149	72
		domInteractive	16	76	42	16	7
		backgroundConnect	7	82	35	27	13
		firstReactRender	68	158	106	16	8
		getState	6	60	26	20	10
		initialActions	0	1	0	0	0
		loadScripts	1269	1699	1448	115	55
		setupStore	12	68	26	19	9
		uiStartup	1997	2655	2229	159	76

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -114 Bytes (-0.00%)
• common: 0 Bytes (0.00%)