Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Copy updates to satisfy UK regulation requirements #28157

Merged
merged 8 commits into from
Oct 30, 2024

Conversation

georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Oct 29, 2024

Description

This PR updates copy on certain ramps components to satisfy UK regulatory requirements. The copy changes have been reviewed and approved by legal and the user experience content team.

The Ramps Banner has been removed on the NFT tab for similar reasons.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screenshot 2024-10-29 at 9 55 31 AM Screenshot 2024-10-29 at 9 55 20 AM Screenshot 2024-10-29 at 9 55 09 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgeweiler georgeweiler changed the title feat (ramps): Copy updates to satisfy UK regulation requirements feat: Copy updates to satisfy UK regulation requirements Oct 29, 2024
@georgeweiler georgeweiler marked this pull request as ready for review October 29, 2024 18:44
@georgeweiler georgeweiler requested review from a team as code owners October 29, 2024 18:44
@metamaskbot
Copy link
Collaborator

Builds ready [05d946c]
Page Load Metrics (2471 ± 200 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27133582300775372
domContentLoaded185632642440404194
load187833572471415200
domInteractive19110582512
backgroundConnect980312411
firstReactRender932801334521
getState8151433617
initialActions00000
loadScripts134224951834338162
setupStore1377342110
uiStartup212738112784488234
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -1005 Bytes (-0.01%)
  • common: -659 Bytes (-0.01%)

Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not update the en_GB locale file. Is that intentional?

@georgeweiler
Copy link
Contributor Author

This does not update the en_GB locale file. Is that intentional?

@danjm this was not intentional, but is the en_GB file used? It was not updated by running verify-locales:fix. 🤔 Should this be a manual update?

@danjm
Copy link
Contributor

danjm commented Oct 30, 2024

@danjm this was not intentional, but is the en_GB file used? It was not updated by running verify-locales:fix. 🤔 Should this be a manual update?

Yeah, my mistake. It is not actually used in the application code in a way that is visible to users

@georgeweiler georgeweiler added this pull request to the merge queue Oct 30, 2024
@dabossdana
Copy link

Yes this should be done manually

Merged via the queue into develop with commit d61b77e Oct 30, 2024
76 checks passed
@georgeweiler georgeweiler deleted the RAMPS-1786-UK-copy-regulation branch October 30, 2024 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-ramp
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants