Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: contact names should not allow duplication #28249

Merged
merged 20 commits into from
Nov 20, 2024
Merged

fix: contact names should not allow duplication #28249

merged 20 commits into from
Nov 20, 2024

Commits on Oct 31, 2024

  1. fix: prevent duplicate names when adding a contact

    @Matt561
    Matt561 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d690771 View commit details
    Browse the repository at this point in the history

  2. fix: prevent duplicate names when editing an existing contact

    @Matt561
    Matt561 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    48658be View commit details
    Browse the repository at this point in the history

  3. fix: perform name validation on ENS input when adding contact

    @Matt561
    Matt561 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    95f69b2 View commit details
    Browse the repository at this point in the history

  4. feat: added placeholder to username input when adding new contact

    @Matt561
    Matt561 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    bdfd821 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. chore: added tests for duplicate username input

    @Matt561
    Matt561 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    2958a91 View commit details
    Browse the repository at this point in the history

  2. feat: added duplicate contact warning banner to contact list

    @Matt561
    Matt561 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    289042c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into fix/26621-contact-names-should-not-allow-… 

    …duplication
    @Matt561
    Matt561 authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    05c9725 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge branch 'develop' into fix/26621-contact-names-should-not-allow-… 

    …duplication
    @Matt561
    Matt561 authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a01ed8a View commit details
    Browse the repository at this point in the history

  2. fix: fixed breaking edit-contact.test.js

    @Matt561
    Matt561 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f4e5925 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into fix/26621-contact-names-should-not-allow-… 

    …duplication
    @Matt561
    Matt561 authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ebabefa View commit details
    Browse the repository at this point in the history

  4. fix: mock lookupDomainName in add-contact.test.js

    @Matt561
    Matt561 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e632185 View commit details
    Browse the repository at this point in the history

  5. fix: remove unit from zero integer in duplicate-contact-banner style

    @Matt561
    Matt561 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    16e2f38 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into fix/26621-contact-names-should-not-allow-… 

    …duplication
    @Matt561
    Matt561 authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    66945ee View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. fix: improvements based on PR review comments

    @Matt561
    Matt561 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ef8cd1b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into fix/26621-contact-… 

    …names-should-not-allow-duplication
    @Matt561
    Matt561 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c0a6baf View commit details
    Browse the repository at this point in the history

  3. fix: replaced type anys in contact-list utils

    @Matt561
    Matt561 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3ac63bc View commit details
    Browse the repository at this point in the history

  4. fix: fixed contact-list-tab story that was failing due to missing int… 

    …ernalAccounts prop
    @Matt561
    Matt561 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f1351c6 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. feat: added duplicate contact warning icon in contact list

    @Matt561
    Matt561 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    b73e844 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix/26621-contact-names-should-not-allow-… 

    …duplication
    @Matt561
    Matt561 authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e8b47de View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Merge branch 'develop' into fix/26621-contact-names-should-not-allow-… 

    …duplication
    @Matt561
    Matt561 authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5d7fcc6 View commit details
    Browse the repository at this point in the history