Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change expand icon per new design #28267

Merged
merged 5 commits into from
Nov 11, 2024
Merged

feat: change expand icon per new design #28267

merged 5 commits into from
Nov 11, 2024

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Nov 4, 2024

Description

Changes the expand icon from left-right to up-down
Also moves the arrow to the left of the text

Open in GitHub Codespaces

Related issues

Fixes: #3490

Manual testing steps

  1. Perform a swap on Uniswap and verify data is decoded into multiple functions.
  2. Check that the expanded rows have correct arrows per design

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner November 4, 2024 14:39
Copy link
Contributor

github-actions bot commented Nov 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Nov 4, 2024
@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner November 4, 2024 15:03
@pnarayanaswamy pnarayanaswamy changed the title Change icon feat: change expand icon per new design Nov 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [bb0c3ea]
Page Load Metrics (2003 ± 144 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint173629502005292140
domContentLoaded167929201967295142
load169829552003299144
domInteractive25111522311
backgroundConnect107434189
firstReactRender50120872311
getState55522189
initialActions01000
loadScripts122624201479271130
setupStore126829199
uiStartup189231352208303145
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pnarayanaswamy pnarayanaswamy added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2024
@pnarayanaswamy pnarayanaswamy added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 3701940 Nov 11, 2024
76 checks passed
@pnarayanaswamy pnarayanaswamy deleted the change-icon branch November 11, 2024 11:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants