Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable simulation metrics for redesign transactions #28280

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Nov 5, 2024

Description

Enables simulation metrics for redesigned transactions

Open in GitHub Codespaces

Related issues

Fixes: #28292

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Nov 5, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [8575b9c]
Page Load Metrics (1888 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22421091816385185
domContentLoaded16642096185611957
load16762113188812761
domInteractive297645136
backgroundConnect895292412
firstReactRender501671012613
getState46317189
initialActions00000
loadScripts1193155013749948
setupStore1168262110
uiStartup18382355212414067
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 68 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@digiwand digiwand marked this pull request as ready for review November 5, 2024 11:18
@digiwand digiwand requested a review from a team as a code owner November 5, 2024 11:18
@digiwand digiwand changed the title feat: enable metrics for redesign transactions feat: Enable simulation metrics for redesign transactions Nov 5, 2024
@digiwand digiwand added this pull request to the merge queue Nov 6, 2024
Merged via the queue into develop with commit 64424be Nov 6, 2024
86 checks passed
@digiwand digiwand deleted the fix-redesign-simulation-metrics branch November 6, 2024 12:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 6, 2024
@digiwand digiwand added rc-cherry-picked release-12.7.0 Issue or pull request that will be included in release 12.7.0 and removed release-12.8.0 Issue or pull request that will be included in release 12.8.0 labels Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
rc-cherry-picked release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat]: Enable Simulation Metrics on Redesigned Transactions
5 participants