Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: btc send flow e2e #28340

Merged
merged 28 commits into from
Nov 13, 2024
Merged

feat: btc send flow e2e #28340

merged 28 commits into from
Nov 13, 2024

Conversation

montelaidev
Copy link
Contributor

Description

This PR reintroduces the happy path send flow tests for BTC

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/668

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [da39a9a]
Page Load Metrics (1759 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1531193917589144
domContentLoaded1522188117228340
load1532194017599144
domInteractive15236534421
backgroundConnect86932199
firstReactRender47218904421
getState55619178
initialActions01000
loadScripts1086139412497837
setupStore1087322612
uiStartup17112340198014770
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 279 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@montelaidev montelaidev marked this pull request as ready for review November 7, 2024 11:47
@montelaidev montelaidev requested a review from a team as a code owner November 7, 2024 11:47
@montelaidev montelaidev self-assigned this Nov 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [31d17f2]
Page Load Metrics (2147 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30325052053441212
domContentLoaded18462491212418187
load18562509214718287
domInteractive34176633015
backgroundConnect989242210
firstReactRender521671093316
getState562272311
initialActions01000
loadScripts13081808153415373
setupStore1273302110
uiStartup20982773241719292
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 279 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

test/e2e/flask/btc/btc-send.spec.ts Show resolved Hide resolved
test/e2e/flask/btc/btc-send.spec.ts Outdated Show resolved Hide resolved
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@metamaskbot
Copy link
Collaborator

Builds ready [4c0ee13]
Page Load Metrics (1987 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16882401197915876
domContentLoaded16762333194615273
load16892399198715474
domInteractive1791492110
backgroundConnect1293392813
firstReactRender712861376230
getState56520209
initialActions00000
loadScripts11681726141914168
setupStore669212110
uiStartup188326552294211102
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 279 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@montelaidev montelaidev added this pull request to the merge queue Nov 13, 2024
Merged via the queue into develop with commit caf6b24 Nov 13, 2024
76 checks passed
@montelaidev montelaidev deleted the feat/btc-send-e2e branch November 13, 2024 09:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants