Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump @metamask/queued-request-controller with patch fix #28355

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Nov 7, 2024

Description

Bumps version of QueuedRequestController, with a patch that fixes an issue where QueuedRequestController.state.queuedRequestCount is not updated after flushing requests for an origin

References

Fixes

Fixes #28358

Slack discussion in v12.7.0 RC Thread

Before

https://drive.google.com/file/d/1ujdQgVLlT8KlwRwO-Cc3XvRHPrkpxIg_/view?usp=drive_link

After

Screen.Recording.2024-11-06.at.3.41.05.PM.mov

Open in GitHub Codespaces

Manual testing steps

On a dapp permissioned for chain A and B, on chain A, queue up one send transaction, then use wallet_switchEthereumChain to switch to chain B, then queue up several more send transactions. Reject/approve the first transaction. Afterwards, you should see chain B as the active chain for the dapp, and all subsequent approvals cleared/rejected automatically.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@adonesky1 adonesky1 requested a review from a team as a code owner November 7, 2024 14:33
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1 adonesky1 changed the title update @metamask/queued-request-controller with patch fix fix: bump @metamask/queued-request-controller with patch fix Nov 7, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/queued-request-controller@7.0.1 None 0 168 kB metamaskbot

🚮 Removed packages: npm/@metamask/queued-request-controller@7.0.0

View full report↗︎

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [f080630]
Page Load Metrics (2030 ± 117 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42924011842481231
domContentLoaded170426281989235113
load175126732030243117
domInteractive19246645024
backgroundConnect7152494120
firstReactRender553851538943
getState6126283215
initialActions00000
loadScripts12181893143518388
setupStore1197342612
uiStartup194533132370371178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 27 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into develop with commit fce0fe4 Nov 7, 2024
95 of 96 checks passed
@adonesky1 adonesky1 deleted the ad/queued-request-controller-patch branch November 7, 2024 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Confirmations not correctly cleared after switching chains
4 participants