Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable account syncing #28359

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Nov 7, 2024

This PR disables account syncing.
The QA team found a critical bug that prevents us from being confident enough to release this feature now. We'll continue investigating and we'll re-enable when we're 100% confident about this.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. No testing steps. Account syncing is disabled

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mathieuartu mathieuartu added the team-notifications Notifications team label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mathieuartu mathieuartu marked this pull request as ready for review November 7, 2024 15:45
@mathieuartu mathieuartu requested a review from a team as a code owner November 7, 2024 15:45
Copy link
Contributor

@matteoscurati matteoscurati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathieuartu mathieuartu added this pull request to the merge queue Nov 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [83dc0bd]
Page Load Metrics (2161 ± 193 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41023941923533256
domContentLoaded164537092127400192
load165737492161402193
domInteractive18158493316
backgroundConnect8122393216
firstReactRender823771488038
getState689272612
initialActions01000
loadScripts115127721571311149
setupStore1194372713
uiStartup190341872499465223
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 155 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit afa7365 Nov 7, 2024
81 of 82 checks passed
@mathieuartu mathieuartu deleted the fix/disable_account_syncing branch November 7, 2024 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants