fix: Test Snap Cronjob can trigger a cronjob to open a di... flaky tests

[hjetpoluru]

Description

This flaky test is due to the dialog taking time to appear and disappear, which is the expected behavior. I have attached a video demonstrating the current behavior.

Cronjob-snap.mov

To address this issue, I added retry logic and validation. However, I noticed that when the dialog does not appear, switchToWindowWithTitle method throws an exception and fails the test hence causing the retry logic to be ineffective. Implementation is in the first commit in this PR b97dbbe.

Fixing this issue within the framework would require significant effort and could impact other tests. Therefore, I have implemented a wait period before attempting to switch to the window. This approach ensures that the dialog has enough time to appear, thereby reducing the likelihood of test failures.

Related issues

Fixes:
#28154

Manual testing steps

Run the test locally or in codespaces using below command
yarn
yarn build:test:webpack
ENABLE_MV3=false yarn test:e2e:single test/e2e/snaps/test-snap-cronjob.spec.js --browser=chrome --leave-running

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [5f92210]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2244 ± 108 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	313	2681	2054	619	297
		domContentLoaded	1864	2566	2198	222	106
		load	1878	2668	2244	224	108
		domInteractive	18	90	50	21	10
		backgroundConnect	9	93	48	30	14
		firstReactRender	81	366	155	71	34
		getState	7	93	28	25	12
		initialActions	0	1	0	0	0
		loadScripts	1363	1931	1645	179	86
		setupStore	8	59	17	15	7
		uiStartup	2090	3142	2569	275	132

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[HowardBraham]

We should remove the comment wait for a maximum of 65 seconds

It used to do that in a previous version, but it no longer does, and that's actually the problem here. It used to have
windowHandles = await driver.waitUntilXWindowHandles(3, 1000, 65000);

I researched it, and there's no easy way to increase the timeout in my new switchToWindowWithTitle (oops)

[hjetpoluru]

Sure, I will remove the comment. Thanks for checking @HowardBraham.

[chloeYue]

LGTM

[metamaskbot]

Builds ready [7a33bab]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2731 ± 682 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	475	6826	2231	1388	667
		domContentLoaded	1632	6704	2699	1406	675
		load	1636	6833	2731	1420	682
		domInteractive	28	386	106	101	48
		backgroundConnect	6	194	39	41	20
		firstReactRender	49	683	216	171	82
		getState	6	112	28	30	15
		initialActions	0	0	0	0	0
		loadScripts	1193	5645	2041	1153	554
		setupStore	5	119	24	30	14
		uiStartup	1822	7823	3160	1660	797

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)