feat: display ERC20 and ERC721 token details returns by decoding api #28366

jpuri · 2024-11-07T18:55:48Z

Description

Add estimated changes display for ERC20 token and NFTs.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3614

Manual testing steps

Enable signature decoding api
On test dapp submit permit request
Check simulation section

Screenshots/Recordings

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-07T18:56:00Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…sion into decoding_api_int

…tension into decoding_ui_changes

…extension into decoded_token_display

metamaskbot · 2024-11-11T10:47:35Z

Builds ready [c9fed99]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1915 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	307	2136	1813	367	176
		domContentLoaded	1620	2402	1885	162	78
		load	1630	2416	1915	168	81
		domInteractive	28	80	48	16	8
		backgroundConnect	8	81	30	25	12
		firstReactRender	65	285	122	50	24
		getState	5	46	11	9	4
		initialActions	0	1	0	0	0
		loadScripts	1162	1765	1371	140	67
		setupStore	6	88	27	26	12
		uiStartup	1827	2657	2173	185	89

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -103.91 KiB (-2.28%)
ui: 7.06 KiB (0.09%)
common: 107.1 KiB (1.30%)

metamaskbot · 2024-11-15T13:34:26Z

Builds ready [9ffc37f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2315 ± 116 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	325	2731	2209	494	237
		domContentLoaded	1900	2630	2278	241	116
		load	1952	2700	2315	242	116
		domInteractive	15	110	62	25	12
		backgroundConnect	11	70	33	20	10
		firstReactRender	94	395	146	63	30
		getState	8	85	38	29	14
		initialActions	0	1	0	0	0
		loadScripts	1393	1980	1691	192	92
		setupStore	6	57	13	11	5
		uiStartup	2172	3550	2633	359	173

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -106.79 KiB (-1.76%)
ui: 2.88 KiB (0.04%)
common: 107.1 KiB (1.29%)

...mponents/confirm/info/typed-sign/permit-simulation/decoded-simulation/decoded-simulation.tsx

...mations/components/confirm/info/typed-sign/permit-simulation/value-display/value-display.tsx

…extension into decoded_token_display

metamaskbot · 2024-11-19T14:08:26Z

Builds ready [c6648ee]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2121 ± 88 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	320	2599	1978	572	275
		domContentLoaded	1783	2484	2079	160	77
		load	1791	2596	2121	183	88
		domInteractive	29	102	50	19	9
		backgroundConnect	8	154	45	39	19
		firstReactRender	54	300	131	75	36
		getState	51	289	127	66	32
		initialActions	0	0	0	0	0
		loadScripts	1320	1910	1571	134	64
		setupStore	6	100	20	29	14
		uiStartup	2253	3485	2600	367	176

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -106.79 KiB (-1.76%)
ui: 2.87 KiB (0.04%)
common: 107.1 KiB (1.29%)

metamaskbot · 2024-11-20T01:25:31Z

Builds ready [ddcde0b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2062 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	403	2518	1992	401	193
		domContentLoaded	1797	2370	2028	146	70
		load	1808	2566	2062	168	81
		domInteractive	31	72	44	11	6
		backgroundConnect	7	193	29	41	20
		firstReactRender	73	297	116	47	23
		getState	48	168	99	27	13
		initialActions	0	1	0	0	0
		loadScripts	1323	1738	1513	121	58
		setupStore	6	41	11	8	4
		uiStartup	2131	3326	2419	253	121

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -106.79 KiB (-1.76%)
ui: 2.87 KiB (0.04%)
common: 107.1 KiB (1.29%)

jpuri added 3 commits November 7, 2024 14:56

UI changes to show decoding data for permits

03b89d8

Merge branch 'develop' into decoding_ui_changes

75026e4

Display ERC20 and ERC721 token details returns by decoding api

7fed6fa

jpuri requested review from a team as code owners November 7, 2024 18:55

metamaskbot added the team-confirmations Push issues to confirmations team label Nov 7, 2024

jpuri and others added 13 commits November 8, 2024 00:26

Merge branch 'decoding_ui_changes' into decoded_token_display

cac71e1

Update signature controller and integrate decoding api

602fb20

Update signature controller and integrate decoding api

fc6ab5e

Update LavaMoat policies

228796c

update

2943ebf

Merge branch 'decoding_api_int' of github.com:MetaMask/metamask-exten…

4b04930

…sion into decoding_api_int

UI changes to show decoding data for permits

25e9a00

Merge branch 'decoding_ui_changes' of github.com:MetaMask/metamask-ex…

fbfdfa3

…tension into decoding_ui_changes

Merge branch 'decoding_ui_changes' into decoded_token_display

cdbfe3b

update

45f64fe

Merge branch 'decoded_token_display' of github.com:MetaMask/metamask-…

dcc66cc

…extension into decoded_token_display

update

b4347bf

update

c9fed99

Base automatically changed from decoding_ui_changes to develop November 15, 2024 12:14

mirceanis requested a review from a team as a code owner November 15, 2024 12:14

jpuri added 2 commits November 15, 2024 18:06

merge

f3b4938

Merge branch 'develop' into decoded_token_display

9ffc37f

jpuri enabled auto-merge November 15, 2024 13:02

pedronfigueiredo previously approved these changes Nov 19, 2024

View reviewed changes

matthewwalsh0 requested changes Nov 19, 2024

View reviewed changes

update

ca3faed

Merge branch 'decoded_token_display' of github.com:MetaMask/metamask-…

436a6b1

…extension into decoded_token_display

jpuri dismissed pedronfigueiredo’s stale review via 436a6b1 November 19, 2024 13:17

jpuri requested review from pedronfigueiredo and matthewwalsh0 November 19, 2024 13:18

jpuri added 2 commits November 19, 2024 18:55

Merge branch 'develop' into decoded_token_display

6e8a0f1

Merge branch 'develop' into decoded_token_display

c6648ee

pedronfigueiredo approved these changes Nov 19, 2024

View reviewed changes

Merge branch 'develop' into decoded_token_display

ddcde0b

matthewwalsh0 approved these changes Nov 20, 2024

View reviewed changes

jpuri added this pull request to the merge queue Nov 20, 2024

Merged via the queue into develop with commit 1b3f304 Nov 20, 2024
75 checks passed

jpuri deleted the decoded_token_display branch November 20, 2024 09:49

github-actions bot locked and limited conversation to collaborators Nov 20, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: display ERC20 and ERC721 token details returns by decoding api #28366

feat: display ERC20 and ERC721 token details returns by decoding api #28366

jpuri commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

metamaskbot commented Nov 11, 2024

metamaskbot commented Nov 15, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 20, 2024

feat: display ERC20 and ERC721 token details returns by decoding api #28366

feat: display ERC20 and ERC721 token details returns by decoding api #28366

Conversation

jpuri commented Nov 7, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 7, 2024

metamaskbot commented Nov 11, 2024

metamaskbot commented Nov 15, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 20, 2024