feat: display native values returned from decoding api #28374

jpuri · 2024-11-08T05:13:18Z

Description

display native values returned from decoding api

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3617

Manual testing steps

Enable signature decoding api
On test dapp submit permit request
Check simulation section

Screenshots/Recordings

For NFT collection:

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-08T05:13:33Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…sion into decoding_api_int

…tension into decoding_ui_changes

…extension into decoded_token_display

metamaskbot · 2024-11-11T13:28:42Z

Builds ready [8de0e98]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1928 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	465	2188	1770	459	220
		domContentLoaded	1695	2432	1897	191	92
		load	1703	2461	1928	197	95
		domInteractive	29	105	55	23	11
		backgroundConnect	8	119	37	29	14
		firstReactRender	52	180	110	31	15
		getState	4	53	19	17	8
		initialActions	0	0	0	0	0
		loadScripts	1192	1966	1415	184	88
		setupStore	5	63	12	15	7
		uiStartup	1905	2671	2145	208	100

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -103.91 KiB (-2.28%)
ui: 12.2 KiB (0.16%)
common: 107.1 KiB (1.30%)

metamaskbot · 2024-11-20T10:30:59Z

Builds ready [81503b3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2800 ± 213 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	397	3381	2272	975	468
		domContentLoaded	2070	3630	2762	446	214
		load	2103	3646	2800	444	213
		domInteractive	32	135	78	34	17
		backgroundConnect	9	142	50	33	16
		firstReactRender	78	400	140	88	42
		getState	59	299	119	48	23
		initialActions	0	1	0	0	0
		loadScripts	1548	2892	2098	369	177
		setupStore	6	46	13	9	4
		uiStartup	2427	4219	3276	544	261

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 5.24 KiB (0.07%)
common: 0 Bytes (0.00%)

digiwand

minor suggestion to remove the snapshot test. I think the snapshot tests have diminishing returns. With a minor change, there is a lot of change in this PR. I suggest we avoid snapshot tests for smaller, reusable components as they will be tested together in parent snapshots

digiwand · 2024-11-20T14:44:58Z

...confirm/info/typed-sign/permit-simulation/native-value-display/native-value-display.test.tsx

+    );
+
+    expect(await findByText('<0.000001')).toBeInTheDocument();
+    expect(container).toMatchSnapshot();


Seeing how many snapshots were affected in this PR, I favor avoiding snapshots on smaller, reusable components. We can observe nuanced style changes from the parent component(s) that render these smaller components and test specific attributes such as text, behavior, or direct styles.

Suggested change

expect(container).toMatchSnapshot();

...ents/confirm/info/typed-sign/permit-simulation/native-value-display/native-value-display.tsx

...mations/components/confirm/info/typed-sign/permit-simulation/value-display/value-display.tsx

…it-simulation/native-value-display/native-value-display.tsx Co-authored-by: digiwand <20778143+digiwand@users.noreply.github.com>

…it-simulation/value-display/value-display.tsx Co-authored-by: digiwand <20778143+digiwand@users.noreply.github.com>

…xtension into native_value_display

metamaskbot · 2024-11-21T10:28:00Z

Builds ready [455f4b0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2017 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	451	2365	1859	492	236
		domContentLoaded	1777	2311	1982	143	69
		load	1786	2365	2017	155	74
		domInteractive	18	108	53	23	11
		backgroundConnect	9	109	36	26	13
		firstReactRender	91	173	129	24	12
		getState	5	59	17	16	8
		initialActions	0	1	0	0	0
		loadScripts	1295	1758	1479	130	63
		setupStore	6	60	14	15	7
		uiStartup	2005	2618	2257	179	86

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 5.25 KiB (0.07%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-21T16:11:38Z

Builds ready [6a1b4b4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2030 ± 113 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	296	2638	1950	450	216
		domContentLoaded	1612	2556	1978	216	104
		load	1622	2650	2030	236	113
		domInteractive	17	211	50	40	19
		backgroundConnect	8	106	53	29	14
		firstReactRender	69	399	212	117	56
		getState	5	91	28	30	14
		initialActions	0	1	0	0	0
		loadScripts	1135	1982	1445	194	93
		setupStore	6	86	23	26	13
		uiStartup	1826	3006	2432	355	171

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 5.25 KiB (0.07%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-22T00:41:28Z

Builds ready [266a002]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1953 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1789	2342	1956	127	61
		domContentLoaded	1730	2249	1908	118	57
		load	1790	2358	1953	129	62
		domInteractive	24	81	37	14	7
		backgroundConnect	14	106	45	29	14
		firstReactRender	64	141	103	22	11
		getState	6	61	17	15	7
		initialActions	0	1	0	0	0
		loadScripts	1241	1667	1385	100	48
		setupStore	7	57	19	17	8
		uiStartup	2003	2668	2161	148	71

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 5.25 KiB (0.07%)
common: 0 Bytes (0.00%)

jpuri added 7 commits November 7, 2024 14:56

UI changes to show decoding data for permits

03b89d8

Merge branch 'develop' into decoding_ui_changes

75026e4

Display ERC20 and ERC721 token details returns by decoding api

7fed6fa

Merge branch 'decoding_ui_changes' into decoded_token_display

cac71e1

Display native values returned from decoding api

8457fd3

Display native values returned from decoding api

569abbc

Display native values returned from decoding api

4810bdd

jpuri requested a review from a team as a code owner November 8, 2024 05:13

metamaskbot added the team-confirmations Push issues to confirmations team label Nov 8, 2024

Display native values returned from decoding api

399086b

jpuri requested a review from a team as a code owner November 8, 2024 09:53

jpuri and others added 17 commits November 11, 2024 10:23

Update signature controller and integrate decoding api

602fb20

Update signature controller and integrate decoding api

fc6ab5e

Update LavaMoat policies

228796c

update

2943ebf

Merge branch 'decoding_api_int' of github.com:MetaMask/metamask-exten…

4b04930

…sion into decoding_api_int

UI changes to show decoding data for permits

25e9a00

Merge branch 'decoding_ui_changes' of github.com:MetaMask/metamask-ex…

fbfdfa3

…tension into decoding_ui_changes

Merge branch 'decoding_ui_changes' into decoded_token_display

cdbfe3b

update

45f64fe

Merge branch 'decoded_token_display' of github.com:MetaMask/metamask-…

dcc66cc

…extension into decoded_token_display

update

b4347bf

update

c9fed99

Merge branch 'decoded_token_display' into native_value_display

494fb15

update

8671d56

update

82f42b0

update

a24d06c

update

8de0e98

merge

81503b3

digiwand requested changes Nov 20, 2024

View reviewed changes

jpuri and others added 3 commits November 21, 2024 14:55

Update ui/pages/confirmations/components/confirm/info/typed-sign/perm…

170d3fa

…it-simulation/native-value-display/native-value-display.tsx Co-authored-by: digiwand <20778143+digiwand@users.noreply.github.com>

Update ui/pages/confirmations/components/confirm/info/typed-sign/perm…

e6678a2

…it-simulation/value-display/value-display.tsx Co-authored-by: digiwand <20778143+digiwand@users.noreply.github.com>

update

30dcc28

jpuri requested a review from digiwand November 21, 2024 09:29

jpuri added 4 commits November 21, 2024 15:00

Merge branch 'develop' into native_value_display

627668f

update

52ff8aa

Merge branch 'native_value_display' of github.com:MetaMask/metamask-e…

428af63

…xtension into native_value_display

update

455f4b0

digiwand approved these changes Nov 21, 2024

View reviewed changes

pedronfigueiredo approved these changes Nov 21, 2024

View reviewed changes

jpuri added this pull request to the merge queue Nov 21, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024

jpuri added this pull request to the merge queue Nov 21, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024

Merge branch 'develop' into native_value_display

b43f63b

jpuri enabled auto-merge November 21, 2024 15:10

Merge branch 'develop' into native_value_display

6a1b4b4

Merge branch 'develop' into native_value_display

266a002

jpuri added this pull request to the merge queue Nov 22, 2024

Merged via the queue into develop with commit 095e2eb Nov 22, 2024
75 checks passed

jpuri deleted the native_value_display branch November 22, 2024 00:50

github-actions bot locked and limited conversation to collaborators Nov 22, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: display native values returned from decoding api #28374

feat: display native values returned from decoding api #28374

jpuri commented Nov 8, 2024 •

edited

Loading

github-actions bot commented Nov 8, 2024

metamaskbot commented Nov 11, 2024

metamaskbot commented Nov 20, 2024

digiwand left a comment

digiwand Nov 20, 2024

metamaskbot commented Nov 21, 2024

metamaskbot commented Nov 21, 2024

metamaskbot commented Nov 22, 2024

feat: display native values returned from decoding api #28374

feat: display native values returned from decoding api #28374

Conversation

jpuri commented Nov 8, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 8, 2024

metamaskbot commented Nov 11, 2024

metamaskbot commented Nov 20, 2024

digiwand left a comment

Choose a reason for hiding this comment

digiwand Nov 20, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 21, 2024

metamaskbot commented Nov 21, 2024

metamaskbot commented Nov 22, 2024

jpuri commented Nov 8, 2024 •

edited

Loading