Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix test path on CI #28482

Merged
merged 1 commit into from
Nov 15, 2024
Merged

chore: fix test path on CI #28482

merged 1 commit into from
Nov 15, 2024

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Nov 15, 2024

Description

Fix test path on CI since we have migrated test to TS

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue added the team-extension-platform Extension Platform team label Nov 15, 2024
@chloeYue chloeYue self-assigned this Nov 15, 2024
@chloeYue chloeYue requested review from kumavis and a team as code owners November 15, 2024 13:22
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [bd49a8f]
Page Load Metrics (1967 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44927851833495238
domContentLoaded169726901940209100
load174827831967218105
domInteractive318551168
backgroundConnect893332612
firstReactRender451581032612
getState45814147
initialActions01000
loadScripts12262047143117684
setupStore65414168
uiStartup190030872179247119
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru hjetpoluru self-requested a review November 15, 2024 14:07
@hjetpoluru hjetpoluru added this pull request to the merge queue Nov 15, 2024
Merged via the queue into develop with commit 4d5940e Nov 15, 2024
86 checks passed
@hjetpoluru hjetpoluru deleted the fix-test-path branch November 15, 2024 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants