Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PortfolioView: Selector to determine networks to poll #28502

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 15, 2024

Description

Provides a selector which will be used by the Asset List and Total Aggregated Balances so that both components use the same chain contents to display and sum.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. No visual or manual testing needed, just a selector with unit tests

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner November 15, 2024 19:25
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing changed the title PortfolioView: Selector to determine networks to poll fix: PortfolioView: Selector to determine networks to poll Nov 15, 2024
@darkwing darkwing force-pushed the portfolio-view-selector branch from 8d7ea07 to 0666749 Compare November 15, 2024 19:38
@metamaskbot
Copy link
Collaborator

Builds ready [0f7db3a]
Page Load Metrics (1912 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16582373191620799
domContentLoaded16472302187819795
load165723571912208100
domInteractive30222635225
backgroundConnect9105332914
firstReactRender773851397436
getState55515147
initialActions01000
loadScripts12061800140917484
setupStore66413168
uiStartup189131432216307148
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 195 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [7382576]
Page Load Metrics (2339 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32927832238486234
domContentLoaded19532689229919895
load196427852339211101
domInteractive369756178
backgroundConnect897352914
firstReactRender1083081637235
getState9101342914
initialActions01000
loadScripts13732049170217885
setupStore691312914
uiStartup225432952724300144
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 489 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [559eeb2]
Page Load Metrics (2088 ± 106 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint175424672084222107
domContentLoaded174324512048211101
load175724672088221106
domInteractive30161592713
backgroundConnect11135403617
firstReactRender532111173517
getState65620178
initialActions01000
loadScripts12151872152018388
setupStore668202110
uiStartup195927102325228109
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 349 Bytes (0.00%)

@gambinish gambinish added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@darkwing darkwing added this pull request to the merge queue Nov 18, 2024
@darkwing darkwing mentioned this pull request Nov 18, 2024
7 tasks
Merged via the queue into develop with commit ec8e5fb Nov 18, 2024
83 checks passed
@darkwing darkwing deleted the portfolio-view-selector branch November 18, 2024 21:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants