Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary event prop #28546

Merged
merged 1 commit into from
Nov 26, 2024
Merged

chore: Remove unnecessary event prop #28546

merged 1 commit into from
Nov 26, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Nov 19, 2024

Description

Removes an unnecessary event prop smart_transaction_duplicated.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. This event prop won't be available anymore in some events after submitting a smart transaction.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added the team-transactions Transactions team label Nov 19, 2024
@dan437 dan437 requested a review from a team as a code owner November 19, 2024 17:13
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2117ac1]
Page Load Metrics (1909 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17352146191411354
domContentLoaded17212073187110148
load17342151190911656
domInteractive29204523718
backgroundConnect1080352412
firstReactRender502951479445
getState472921447033
initialActions01000
loadScripts1269153413967938
setupStore67212147
uiStartup198630952404339163
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -44 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

github-merge-queue bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Nov 26, 2024
## **Description**

Removes an unnecessary event prop smart_transaction_duplicated, as we
did in the extension:
MetaMask/metamask-extension#28546

## **Related issues**

Fixes:

## **Manual testing steps**

1. This event prop won't be available anymore in some events after
submitting a smart transaction.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@httpJunkie httpJunkie self-requested a review November 26, 2024 17:54
Copy link

@httpJunkie httpJunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change n removal of props that are unecessary

@dan437 dan437 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 2a06244 Nov 26, 2024
83 checks passed
@dan437 dan437 deleted the remove-event-props branch November 26, 2024 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-transactions Transactions team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants