Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sentry sampling): divide by 2 our sentry trace sample rate to avoid exceeding our quota #28573

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

gauthierpetetin
Copy link
Contributor

Description

  • Divide by 2 our sentry trace sample rate to avoid exceeding our quota

Related issues

Fixes: None

Manual testing steps

  • None

Screenshots/Recordings

  • None

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin added area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. team-extension-platform Extension Platform team labels Nov 20, 2024
@gauthierpetetin gauthierpetetin self-assigned this Nov 20, 2024
@gauthierpetetin gauthierpetetin requested a review from a team as a code owner November 20, 2024 17:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjetpoluru hjetpoluru self-requested a review November 20, 2024 19:10
@metamaskbot
Copy link
Collaborator

Builds ready [768aa11]
Page Load Metrics (2161 ± 120 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33427232059456219
domContentLoaded176727132133249120
load178327262161250120
domInteractive199046189
backgroundConnect985252211
firstReactRender663941469345
getState482991255426
initialActions01000
loadScripts133721451626223107
setupStore683192713
uiStartup213932172627307147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit 62430fb Nov 20, 2024
75 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/sentry-trace-sample-rate branch November 20, 2024 20:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-extension-platform Extension Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants