fix: swaps approval checking for approvals between 0 and unlimited

[jclancy93]

Description

For approval amounts that were greater than 0, but less than the amount the user was trying to swap. The swaps controller was filtering out quotes for users. This PR fixes a longstanding bug in the swaps controller, where we only checked if the approval amount was 0. Instead of when the approval is 0 OR approval amount is less than swap amount. This PR updates the logic to correctly reflect this case

Related issues

Fixes issue reported in Slack here https://consensys.slack.com/archives/C0220SURQ3E/p1732474780474849

Manual testing steps

Testing wallet with seeded state:

1. Load this wallet into your MetaMask
2. Try and Swap 1 USDC for Polygon on Polygon
3. Quotes should be returned

New Testing Wallet

1. Create a swaps approval for some small amount
2. Try and swap a larger amount
3. Swaps quotes should be returned

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [84447ae]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2098 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	308	2487	1999	426	204
		domContentLoaded	1785	2495	2054	192	92
		load	1822	2499	2098	198	95
		domInteractive	25	199	49	38	18
		backgroundConnect	11	100	41	32	15
		firstReactRender	63	157	111	22	11
		getState	8	73	25	20	9
		initialActions	0	1	0	0	0
		loadScripts	1251	1814	1495	148	71
		setupStore	7	65	20	21	10
		uiStartup	2006	2872	2338	228	110

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 24 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [c888749]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1774 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	463	2144	1715	322	155
		domContentLoaded	1550	2087	1742	146	70
		load	1594	2144	1774	157	75
		domInteractive	24	57	35	11	5
		backgroundConnect	11	82	36	23	11
		firstReactRender	72	281	130	49	23
		getState	6	68	18	18	9
		initialActions	0	0	0	0	0
		loadScripts	1107	1597	1281	125	60
		setupStore	6	14	8	2	1
		uiStartup	1746	2646	2015	211	101

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 24 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[infiniteflower]

Tested and working!