-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SonarCloud workflow_run #28693
fix: SonarCloud workflow_run #28693
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [43321e6]
Page Load Metrics (1844 ± 116 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
There was a typo in the name of the workflow, causing the SonarCloud workflow to not run. This PR corrects the mistake.
Related issues
Fixes: https://consensys.slack.com/archives/CTQAGKY5V/p1732116793123109
Manual testing steps
workflow_run
only run on the default branch, we can only make sure that SonarCloud 100% runs after merging. I tested it on a private repository though on my GitHub account, and the workflow worked there.Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist