Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SonarCloud workflow_run #28693

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: SonarCloud workflow_run #28693

merged 1 commit into from
Nov 25, 2024

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Nov 25, 2024

Description

Open in GitHub Codespaces

There was a typo in the name of the workflow, causing the SonarCloud workflow to not run. This PR corrects the mistake.

Related issues

Fixes: https://consensys.slack.com/archives/CTQAGKY5V/p1732116793123109

Manual testing steps

  1. As workflows called by workflow_run only run on the default branch, we can only make sure that SonarCloud 100% runs after merging. I tested it on a private repository though on my GitHub account, and the workflow worked there.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Nov 25, 2024
@itsyoboieltr itsyoboieltr requested a review from a team as a code owner November 25, 2024 16:10
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [43321e6]
Page Load Metrics (1844 ± 116 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36420281644442212
domContentLoaded148725501803237114
load149725821844242116
domInteractive27109472311
backgroundConnect11135373215
firstReactRender1692372311
getState572232211
initialActions01000
loadScripts10771959135219493
setupStore65416157
uiStartup170229212094291140
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itsyoboieltr itsyoboieltr added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 0bf00e6 Nov 25, 2024
80 checks passed
@itsyoboieltr itsyoboieltr deleted the fix/sonarcloud branch November 25, 2024 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants