Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e tests for multichain #28708

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Nov 25, 2024

Description

This PR adds E2E tests for multichain

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur requested a review from a team as a code owner November 25, 2024 23:14
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jonybur jonybur requested a review from gambinish November 25, 2024 23:20
@metamaskbot
Copy link
Collaborator

Builds ready [185a813]
Page Load Metrics (1877 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45222491810340163
domContentLoaded16462216184114469
load17172232187713665
domInteractive267141168
backgroundConnect873332210
firstReactRender187031189
getState75821178
initialActions01000
loadScripts12111572135010550
setupStore666212211
uiStartup18722450209714972
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jonybur jonybur requested a review from a team as a code owner November 26, 2024 12:46
@metamaskbot
Copy link
Collaborator

Builds ready [912714a]
Page Load Metrics (1819 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15832099181116077
domContentLoaded15712084177416579
load15912101181915876
domInteractive26103392110
backgroundConnect1084482211
firstReactRender1686362311
getState66122178
initialActions01000
loadScripts11181593130414369
setupStore6441084
uiStartup17912372201017283
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested, LGTM

@gambinish gambinish added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Nov 26, 2024
@gambinish gambinish added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 4e1d313 Nov 26, 2024
77 checks passed
@gambinish gambinish deleted the jb-e2e-tests-for-multichain branch November 26, 2024 21:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants