feat: adding metrics for signature decoding #28719

jpuri · 2024-11-26T10:22:15Z

Description

Adding metrics for signature decoding.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3644

Manual testing steps

Enable signature deccoding locally
Open permit page
Check that metrics are recorded for signature decoding information

Screenshots/Recordings

NA

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-26T10:22:29Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…sion into decoding_metrics

metamaskbot · 2024-11-26T13:12:25Z

Builds ready [acec502]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1627 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	358	2091	1573	317	152
		domContentLoaded	1428	2079	1608	149	71
		load	1437	2089	1627	155	75
		domInteractive	24	83	44	21	10
		backgroundConnect	6	76	19	17	8
		firstReactRender	15	74	33	23	11
		getState	3	49	16	16	8
		initialActions	0	1	0	0	0
		loadScripts	1017	1560	1174	123	59
		setupStore	6	54	21	20	10
		uiStartup	1615	2246	1818	166	80

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 1.46 KiB (0.02%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-26T13:45:38Z

Builds ready [44c0235]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1607 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1503	2007	1609	115	55
		domContentLoaded	1471	1963	1581	112	54
		load	1480	2017	1607	121	58
		domInteractive	21	88	36	18	9
		backgroundConnect	10	76	28	20	10
		firstReactRender	15	71	25	18	9
		getState	4	42	10	9	4
		initialActions	0	1	0	0	0
		loadScripts	1060	1457	1160	92	44
		setupStore	6	55	15	16	8
		uiStartup	1639	2307	1785	148	71

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 1.46 KiB (0.02%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-26T16:53:52Z

Builds ready [1aec969]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1855 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1511	2324	1853	194	93
		domContentLoaded	1495	2255	1822	185	89
		load	1512	2329	1855	187	90
		domInteractive	15	77	36	14	7
		backgroundConnect	10	90	36	22	10
		firstReactRender	18	98	46	25	12
		getState	6	63	23	20	10
		initialActions	0	1	0	0	0
		loadScripts	1078	1745	1355	159	76
		setupStore	6	50	13	13	6
		uiStartup	1702	2868	2081	256	123

metamaskbot · 2024-11-26T18:23:58Z

Builds ready [3bcd04e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1586 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1439	1865	1589	97	46
		domContentLoaded	1429	1779	1557	90	43
		load	1439	1876	1586	101	48
		domInteractive	22	85	44	21	10
		backgroundConnect	9	101	27	24	11
		firstReactRender	15	77	35	24	11
		getState	4	55	16	18	9
		initialActions	0	1	0	0	0
		loadScripts	1040	1357	1154	79	38
		setupStore	5	58	9	11	5
		uiStartup	1608	2118	1774	123	59

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 1.46 KiB (0.02%)
common: 0 Bytes (0.00%)

ui/pages/confirmations/components/simulation-details/useDecodedSignatureMetrics.ts

ui/pages/confirmations/components/simulation-details/useDecodedSignatureMetrics.test.ts

…sion into decoding_metrics

matthewwalsh0 · 2024-11-27T13:34:58Z

ui/pages/confirmations/hooks/useDecodedSignatureMetrics.test.ts

+    });
+  });
+
+  it('should call updateSignatureEventFragment with correct parameters if there are no state changes', async () => {


Minor, same name as the other?

…sion into decoding_metrics

digiwand · 2024-11-27T14:06:05Z

ui/pages/confirmations/hooks/useDecodedSignatureMetrics.test.ts

+};
+
+describe('useDecodedSignatureMetrics', () => {
+  process.env.ENABLE_SIGNATURE_DECODING = 'true';


Q: should we unset the ENV var after the tests are complete or is there another way to add ENV for builds?

This is being removed in a following PR

metamaskbot · 2024-11-27T14:21:29Z

Builds ready [e938f4e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1711 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1545	1951	1709	114	55
		domContentLoaded	1519	1910	1680	115	55
		load	1548	1961	1711	113	54
		domInteractive	24	78	42	18	9
		backgroundConnect	11	71	31	18	9
		firstReactRender	17	76	40	24	11
		getState	6	56	15	16	8
		initialActions	0	0	0	0	0
		loadScripts	1104	1451	1251	99	47
		setupStore	6	58	14	17	8
		uiStartup	1725	2151	1905	122	58

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 1.34 KiB (0.02%)
common: 0 Bytes (0.00%)

Adding basic metrics for decoding signatures

67403d5

jpuri added the team-confirmations Push issues to confirmations team label Nov 26, 2024

jpuri requested a review from a team as a code owner November 26, 2024 10:22

jpuri added 2 commits November 26, 2024 16:10

update

d325631

update

f050ef2

jpuri requested a review from a team as a code owner November 26, 2024 11:48

Merge branch 'develop' into decoding_metrics

b255951

jpuri enabled auto-merge November 26, 2024 11:49

jpuri added 3 commits November 26, 2024 17:43

update

64df0f5

Merge branch 'decoding_metrics' of github.com:MetaMask/metamask-exten…

2a83626

…sion into decoding_metrics

update

acec502

Merge branch 'develop' into decoding_metrics

44c0235

Merge branch 'develop' into decoding_metrics

1aec969

Merge branch 'develop' into decoding_metrics

3bcd04e

pedronfigueiredo previously approved these changes Nov 27, 2024

View reviewed changes

matthewwalsh0 requested changes Nov 27, 2024

View reviewed changes

update

aab444e

jpuri requested a review from matthewwalsh0 November 27, 2024 13:33

Merge branch 'decoding_metrics' of github.com:MetaMask/metamask-exten…

b5831c7

…sion into decoding_metrics

jpuri dismissed pedronfigueiredo’s stale review via b5831c7 November 27, 2024 13:33

Merge branch 'develop' into decoding_metrics

441a94e

matthewwalsh0 previously approved these changes Nov 27, 2024

View reviewed changes

jpuri added 3 commits November 27, 2024 19:16

merge

e0c73cf

update

1ea109e

Merge branch 'decoding_metrics' of github.com:MetaMask/metamask-exten…

e938f4e

…sion into decoding_metrics

jpuri dismissed matthewwalsh0’s stale review via e938f4e November 27, 2024 13:48

matthewwalsh0 approved these changes Nov 27, 2024

View reviewed changes

digiwand approved these changes Nov 27, 2024

View reviewed changes

jpuri added this pull request to the merge queue Nov 27, 2024

Merged via the queue into develop with commit afe6dc0 Nov 27, 2024
75 checks passed

jpuri deleted the decoding_metrics branch November 27, 2024 14:29

github-actions bot locked and limited conversation to collaborators Nov 27, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding metrics for signature decoding #28719

feat: adding metrics for signature decoding #28719

jpuri commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

matthewwalsh0 Nov 27, 2024

jpuri Nov 27, 2024

digiwand Nov 27, 2024

jpuri Nov 27, 2024

metamaskbot commented Nov 27, 2024

feat: adding metrics for signature decoding #28719

feat: adding metrics for signature decoding #28719

Conversation

jpuri commented Nov 26, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

matthewwalsh0 Nov 27, 2024

Choose a reason for hiding this comment

jpuri Nov 27, 2024

Choose a reason for hiding this comment

digiwand Nov 27, 2024

Choose a reason for hiding this comment

jpuri Nov 27, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 27, 2024