test: Allow token balance to populate after swap #28744

davibroc · 2024-11-26T20:18:59Z

Add to add a delay to allow the token balance to resolve. The script was going to fast and after swapping the first token the next swap would fail as the balance didn't have enough time to update

Description

Add to add a delay to allow the token balance to resolve. The script was going to fast and after swapping the first token the next swap would fail as the balance didn't have enough time to update

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-26T20:19:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-11-26T20:55:30Z

Builds ready [5d3cfd0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1652 ± 42 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1497	1828	1656	84	40
		domContentLoaded	1478	1809	1625	88	42
		load	1483	1826	1652	86	42
		domInteractive	23	70	36	14	7
		backgroundConnect	9	117	26	25	12
		firstReactRender	16	70	33	22	10
		getState	4	51	14	15	7
		initialActions	0	1	0	0	0
		loadScripts	1068	1332	1194	79	38
		setupStore	6	57	16	19	9
		uiStartup	1645	2019	1839	96	46

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-27T00:34:26Z

Builds ready [04fca2d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1726 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1576	2023	1727	126	61
		domContentLoaded	1514	2002	1694	125	60
		load	1575	2022	1726	127	61
		domInteractive	24	75	38	16	8
		backgroundConnect	11	80	34	22	10
		firstReactRender	16	70	33	22	10
		getState	5	60	17	19	9
		initialActions	0	40	2	9	4
		loadScripts	1113	1526	1254	106	51
		setupStore	6	10	7	1	1
		uiStartup	1743	2228	1919	145	69

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-27T01:25:40Z

Builds ready [6eda1a5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1942 ± 123 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	389	2421	1764	501	241
		domContentLoaded	1590	2383	1910	254	122
		load	1599	2398	1942	255	123
		domInteractive	24	84	45	20	10
		backgroundConnect	6	79	35	23	11
		firstReactRender	16	77	40	23	11
		getState	4	54	18	14	7
		initialActions	0	1	0	0	0
		loadScripts	1168	1815	1433	215	103
		setupStore	6	59	15	15	7
		uiStartup	1757	2685	2172	289	139

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-29T18:22:26Z

Builds ready [6ed9fd5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1947 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	412	2216	1870	353	170
		domContentLoaded	1684	2197	1912	111	53
		load	1750	2216	1947	106	51
		domInteractive	23	197	44	37	18
		backgroundConnect	10	75	36	24	12
		firstReactRender	17	56	24	10	5
		getState	56	116	93	19	9
		initialActions	0	1	0	0	0
		loadScripts	1258	1701	1471	101	49
		setupStore	7	14	9	2	1
		uiStartup	1986	2440	2220	118	57

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-29T22:00:50Z

Builds ready [cfa41a1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1776 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1599	2283	1778	153	74
		domContentLoaded	1591	2236	1753	146	70
		load	1596	2301	1776	155	74
		domInteractive	24	89	33	16	8
		backgroundConnect	7	61	22	17	8
		firstReactRender	15	48	19	8	4
		getState	44	114	89	20	9
		initialActions	0	1	0	0	0
		loadScripts	1208	1578	1331	103	49
		setupStore	6	16	8	3	1
		uiStartup	1801	2899	2026	247	119

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

davibroc added team-swaps QA Passed labels Nov 26, 2024

davibroc requested a review from a team as a code owner November 26, 2024 20:19

davibroc force-pushed the test/fix-zero-balance branch from 04fca2d to 6eda1a5 Compare November 27, 2024 00:52

davibroc added 5 commits November 29, 2024 09:47

Allow token balance to populate

eee8b02

Mark test as fail if balance is zero

aef347d

Increase timeout

02e8dee

Remove zero balance check

4994edd

Add more delays

6ed9fd5

davibroc force-pushed the test/fix-zero-balance branch from 9734c2d to 6ed9fd5 Compare November 29, 2024 17:51

davibroc added 4 commits November 29, 2024 10:37

Added checks for token balance

e1eb17b

added waitForBalance

0ec61bc

Improved waitForTokenBalance

04d04a2

Fixed lint

cfa41a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Allow token balance to populate after swap #28744

test: Allow token balance to populate after swap #28744

davibroc commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 29, 2024

metamaskbot commented Nov 29, 2024

test: Allow token balance to populate after swap #28744

Are you sure you want to change the base?

test: Allow token balance to populate after swap #28744

Conversation

davibroc commented Nov 26, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 29, 2024

metamaskbot commented Nov 29, 2024

davibroc commented Nov 26, 2024 •

edited

Loading