-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add dispatch detect Nfts on network switch #28769
Merged
sahar-fehri
merged 2 commits into
develop
from
fix/dispatch-detect-nft-on-network-switch
Nov 27, 2024
Merged
fix: add dispatch detect Nfts on network switch #28769
sahar-fehri
merged 2 commits into
develop
from
fix/dispatch-detect-nft-on-network-switch
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sahar-fehri
commented
Nov 27, 2024
@@ -287,6 +288,7 @@ export const NetworkListMenu = ({ onClose }: { onClose: () => void }) => { | |||
dispatch(toggleNetworkMenu()); | |||
dispatch(updateCustomNonce('')); | |||
dispatch(setNextNonce('')); | |||
dispatch(detectNfts()); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are caching the calls to the NFT-API so its okay if this call is made multiple times
sahar-fehri
added
the
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
label
Nov 27, 2024
salimtb
approved these changes
Nov 27, 2024
Builds ready [5ed1fc8]
Page Load Metrics (1915 ± 139 ms)
Bundle size diffs
|
gambinish
approved these changes
Nov 27, 2024
jonybur
approved these changes
Nov 27, 2024
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to fix detecting NFTs when a user switches networks while on the NFT tab
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-11-27.at.14.37.54.mov
After
Screen.Recording.2024-11-27.at.14.35.08.mov
Pre-merge author checklist
Pre-merge reviewer checklist