Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dispatch detect Nfts on network switch #28769

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Nov 27, 2024

Description

PR to fix detecting NFTs when a user switches networks while on the NFT tab

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screen.Recording.2024-11-27.at.14.37.54.mov

After

Screen.Recording.2024-11-27.at.14.35.08.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -287,6 +288,7 @@ export const NetworkListMenu = ({ onClose }: { onClose: () => void }) => {
dispatch(toggleNetworkMenu());
dispatch(updateCustomNonce(''));
dispatch(setNextNonce(''));
dispatch(detectNfts());

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are caching the calls to the NFT-API so its okay if this call is made multiple times

@sahar-fehri sahar-fehri marked this pull request as ready for review November 27, 2024 13:38
@sahar-fehri sahar-fehri requested a review from a team as a code owner November 27, 2024 13:38
@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Nov 27, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [5ed1fc8]
Page Load Metrics (1915 ± 139 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24921541472681327
domContentLoaded154729441869296142
load155629541915289139
domInteractive288048189
backgroundConnect794482813
firstReactRender1672382010
getState46619168
initialActions01000
loadScripts111922661388242116
setupStore66415157
uiStartup178933132138326156
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sahar-fehri sahar-fehri added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit a2651c0 Nov 27, 2024
75 checks passed
@sahar-fehri sahar-fehri deleted the fix/dispatch-detect-nft-on-network-switch branch November 27, 2024 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants