-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Unflatten downstream references to metamask
Redux slice (5/5)
#28776
Draft
MajorLift
wants to merge
86
commits into
jongsun/perf/redux/241204-unflatten-metamask-slice
Choose a base branch
from
jongsun/perf/redux/241127-unflatten-downstream-references-to-metamask-slice
base: jongsun/perf/redux/241204-unflatten-metamask-slice
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+5,203
−4,488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
MajorLift
changed the base branch from
develop
to
jongsun/perf/redux/241008-unflatten-MetamaskController-stores
November 27, 2024 16:03
7 tasks
gauthierpetetin
added
the
team-tiger
Tiger team (for tech debt reduction + performance improvements)
label
Nov 27, 2024
MajorLift
force-pushed
the
jongsun/perf/redux/241008-unflatten-MetamaskController-stores
branch
5 times, most recently
from
December 2, 2024 10:11
a7fc45e
to
907d672
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241127-unflatten-downstream-references-to-metamask-slice
branch
from
December 2, 2024 10:13
a1fba1d
to
b75f215
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241008-unflatten-MetamaskController-stores
branch
from
December 2, 2024 19:22
907d672
to
fddacbc
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241127-unflatten-downstream-references-to-metamask-slice
branch
from
December 2, 2024 19:25
b75f215
to
5317fec
Compare
…e-ui-properties-to-appstate-slice
MajorLift
force-pushed
the
jongsun/perf/redux/241008-unflatten-MetamaskController-stores
branch
from
December 4, 2024 14:48
fddacbc
to
f5b6067
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241127-unflatten-downstream-references-to-metamask-slice
branch
2 times, most recently
from
December 4, 2024 15:34
817dfc4
to
0565217
Compare
Define types for metamask controller stores
… are assigned composed controller state objects
MajorLift
force-pushed
the
jongsun/perf/redux/241127-unflatten-downstream-references-to-metamask-slice
branch
from
December 5, 2024 20:07
aedfca6
to
f6cdb0b
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
7 times, most recently
from
December 9, 2024 15:46
ba499fd
to
7ad7c9a
Compare
MajorLift
changed the title
perf: Unflatten downstream references to
perf: Unflatten downstream references to Dec 9, 2024
metamask
Redux slice (3/3)metamask
Redux slice (5/5)
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
8 times, most recently
from
December 11, 2024 09:35
cf9e3ae
to
f854428
Compare
MajorLift
changed the title
perf: Unflatten downstream references to
refactor: Unflatten downstream references to Dec 11, 2024
metamask
Redux slice (5/5)metamask
Redux slice (5/5)
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
6 times, most recently
from
December 12, 2024 17:09
56716cd
to
62df3ae
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
from
December 12, 2024 20:14
af56482
to
b5ddb61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
metamask
Redux slice and convert to TypeScript (2/5) #28929MetamaskController
stores (1/5) #28723metamask
slice toappState
slice #28703Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist