Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master with branch name changes #28873

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 3, 2024

Description

This is a cherry-pick of #28821 and #28823 intended to update the master branch (soon to be renamed to stable) with branch name changes so that CI steps run correctly when the next release is merged.

Open in GitHub Codespaces

Related issues

See #28821 and #28823

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Gudahtt and others added 3 commits December 3, 2024 12:09
Rename references to the main branch. It will be called `main` rather
than `develop`.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28821?quickstart=1)

Relates to MetaMask/MetaMask-planning#3677

N/A

N/A

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Copy link
Contributor

github-actions bot commented Dec 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [baf8183]
Page Load Metrics (1812 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31422651748360173
domContentLoaded16132081178611354
load16262165181213163
domInteractive15203544120
backgroundConnect989282512
firstReactRender51154982211
getState585182211
initialActions00000
loadScripts11481546130210149
setupStore55912147
uiStartup18192500201715474

@Gudahtt Gudahtt added the DO-NOT-MERGE Pull requests that should not be merged label Dec 3, 2024
@Gudahtt Gudahtt marked this pull request as ready for review December 3, 2024 19:30
@Gudahtt Gudahtt requested review from a team, HowardBraham and kumavis as code owners December 3, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE Pull requests that should not be merged team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants