Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky native send and transaction decoding test #29362

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Dec 19, 2024

Description

The test dapp page loads and the element is visible but not enabled yet and this causes sometimes for the test to click on the button too soon and to fail. Added a new wait condition in the waitForSelector method to wait until the element is enabled and then click on it.

Open in GitHub Codespaces

Related issues

Fixes: #28485

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Dec 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c06530d]
Page Load Metrics (1616 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1451177516189345
domContentLoaded1441171415937938
load1451177116169445
domInteractive227341168
backgroundConnect96722189
firstReactRender1693442613
getState55710115
initialActions01000
loadScripts1038129811766833
setupStore65110105
uiStartup16272357186015976
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pnarayanaswamy pnarayanaswamy added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 768716d Dec 23, 2024
83 checks passed
@pnarayanaswamy pnarayanaswamy deleted the fix-flaky-transaction-decoding branch December 23, 2024 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Confirmation Redesign Native Send @no-mmi dApp initi..." flaky tests
4 participants