Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove second inner scroll bar from tx details #29412

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 20, 2024

Description

Open in GitHub Codespaces

This PR removes the 2nd inner scrollbar from Bridge tx details.

Related issues

Fixes:

Manual testing steps

  1. Do a bridge tx
  2. Get navigated to Activity list
  3. Click on a bridge tx
  4. Observe only 1 scroll bar

Screenshots/Recordings

Before

Screenshot 2024-12-20 at 5 03 15 PM

After

Screenshot 2024-12-20 at 5 19 06 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review December 20, 2024 22:23
@infiniteflower infiniteflower requested a review from a team as a code owner December 20, 2024 22:23
@metamaskbot
Copy link
Collaborator

Builds ready [8972ee2]
Page Load Metrics (1605 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1463179916089244
domContentLoaded1449178115838742
load1457179816058742
domInteractive21136453014
backgroundConnect97928178
firstReactRender16179474019
getState56613168
initialActions00000
loadScripts1055137011798340
setupStore67915199
uiStartup163023401893211101
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -32 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

micaelae
micaelae previously approved these changes Jan 7, 2025
ghgoodreau
ghgoodreau previously approved these changes Jan 7, 2025
@infiniteflower infiniteflower dismissed stale reviews from ghgoodreau and micaelae via 070a63d January 7, 2025 19:02
@infiniteflower infiniteflower force-pushed the mb1835-xchain-details-scrollbar branch from 8972ee2 to 070a63d Compare January 7, 2025 19:02
@micaelae micaelae enabled auto-merge January 7, 2025 19:35
@metamaskbot
Copy link
Collaborator

Builds ready [070a63d]
Page Load Metrics (1765 ± 120 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35224841550550264
domContentLoaded140324271744246118
load145324791765250120
domInteractive21227444421
backgroundConnect85323157
firstReactRender16107402713
getState458202010
initialActions01000
loadScripts97818901299208100
setupStore65520209
uiStartup162328402055318153

@micaelae micaelae added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 7, 2025
@infiniteflower infiniteflower added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 7, 2025
@infiniteflower infiniteflower added this pull request to the merge queue Jan 7, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 7, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29412?quickstart=1)

This PR removes the 2nd inner scrollbar from Bridge tx details.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Do a bridge tx
2. Get navigated to Activity list
3. Click on a bridge tx
4. Observe only 1 scroll bar

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->


![Screenshot 2024-12-20 at 5 03
15 PM](https://github.com/user-attachments/assets/52904de2-7264-4959-bf23-6301eb1b7000)

### **After**

<!-- [screenshots/recordings] -->


![Screenshot 2024-12-20 at 5 19
06 PM](https://github.com/user-attachments/assets/744401eb-80bf-4726-8ee4-844068a54978)

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 7, 2025
@infiniteflower infiniteflower added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit dabf173 Jan 7, 2025
77 checks passed
@infiniteflower infiniteflower deleted the mb1835-xchain-details-scrollbar branch January 7, 2025 21:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants