Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add profile_id as a metametrics user trait #30552

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Feb 25, 2025

Description

This PR adds profile_id as a MetaMetrics user trait so that it gets attached to every event when present in the state.

Open in GitHub Codespaces

Related issues

Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-39
Segment PR: https://github.com/Consensys/segment-schema/pull/243

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mathieuartu mathieuartu marked this pull request as ready for review February 25, 2025 16:03
@metamaskbot
Copy link
Collaborator

Builds ready [cdcede6]
Page Load Metrics (1826 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16212082182612560
domContentLoaded15562040179412861
load15672144182613464
domInteractive26114402412
backgroundConnect10102332613
firstReactRender1571362311
getState5421284
initialActions01000
loadScripts11361595134710752
setupStore85419178
uiStartup18282591209918087
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 127 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 25 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [62b87a7]
Page Load Metrics (1846 ± 154 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36121431710353169
domContentLoaded152029371813308148
load153430131846322154
domInteractive27119482914
backgroundConnect1182362311
firstReactRender1581352311
getState66315168
initialActions01000
loadScripts11171808133219393
setupStore870222010
uiStartup177633712111343165
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 127 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 25 Bytes (0.00%)

Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mathieuartu mathieuartu added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit c8995f0 Feb 28, 2025
82 of 83 checks passed
@mathieuartu mathieuartu deleted the feat/metametrics-profile-id-trait branch February 28, 2025 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-identity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants