feat: add metamaskbot codeowner announcement #30668

hmalik88 · 2025-03-02T19:19:07Z

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

What is the reason for the change? We often get tagged for codeowner reviews, it can sometimes be difficult to know what you're reviewing without looking at the CODEOWNER file yourself. It would be nice to know what you need to review upon just visting the PR link.
What is the improvement/solution? Added a new workflow to get the MetaMask bot to post a comment on the files that need a CODEOWNER review categorized by the respective team. The bot will post a comment and then update that comment as needed. It will also delete the comment if there is no longer a CODEOWNER review required.

Manual testing steps

Open a PR against this branch
Make some codeowner file changes
Observe the MetaMask bot make a comment.

Screenshots/Recordings

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-02T19:19:21Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

This reverts commit fa353c3.

hmalik88 · 2025-03-02T21:35:34Z

@metamaskbot update-policies

metamaskbot · 2025-03-02T21:46:04Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-03-02T22:29:46Z

Builds ready [ee3811e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1564 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	352	1740	1507	279	134
		domContentLoaded	1383	1725	1537	84	40
		load	1423	1744	1564	85	41
		domInteractive	19	113	46	26	13
		backgroundConnect	9	98	32	22	11
		firstReactRender	14	67	26	18	9
		getState	4	55	17	18	9
		initialActions	0	0	0	0	0
		loadScripts	1012	1333	1144	80	38
		setupStore	7	25	9	4	2
		uiStartup	1630	2004	1765	101	48

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

HowardBraham

I have not actually tested functionality, do you have a PR open against this that tests it?

package.json

.github/workflows/identify-codeowners.yml

hmalik88 · 2025-03-03T00:05:16Z

I have not actually tested functionality, do you have a PR open against this that tests it?

Yeah, I was testing against #30669

hmalik88 · 2025-03-03T01:14:25Z

Yeah, I was testing against #30669

Okay I tried it out, pretty cool. And this is minor but I think very easy: after we groupFilesByTeam, can we sort the teams themselves in alphabetical order? My test produced this result, which I think isn't sorted on anything:

✨ Files requiring CODEOWNER review ✨

📄 @HowardBraham

development/circular-deps.jsonc

🔒 @MetaMask/extension-security-team

development/circular-deps.jsonc

📈 @MetaMask/ramp

ui/ducks/ramps/ramps.test.ts

🫰 @MetaMask/snaps-devs

ui/helpers/utils/permission.js

🖥️ @MetaMask/wallet-ux

ui/components/multichain/multichain-components.scss

📄 @dbrans

development/circular-deps.jsonc

Nice catch, I updated to sort alphabetically and list the teams first.

metamaskbot · 2025-03-05T14:34:54Z

Builds ready [e02a949]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1865 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1693	2223	1864	128	61
		domContentLoaded	1668	2191	1833	124	60
		load	1693	2219	1865	127	61
		domInteractive	15	145	50	29	14
		backgroundConnect	12	85	39	21	10
		firstReactRender	15	80	47	25	12
		getState	5	59	12	11	5
		initialActions	0	0	0	0	0
		loadScripts	1234	1594	1377	94	45
		setupStore	7	61	15	13	6
		uiStartup	1927	2501	2116	149	71

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-05T16:52:12Z

Builds ready [cdad138]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1830 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1621	2250	1838	198	95
		domContentLoaded	1572	2185	1804	188	90
		load	1622	2258	1830	198	95
		domInteractive	27	191	50	39	19
		backgroundConnect	10	73	26	19	9
		firstReactRender	14	76	42	26	13
		getState	5	64	20	19	9
		initialActions	0	0	0	0	0
		loadScripts	1174	1699	1368	161	77
		setupStore	7	53	13	10	5
		uiStartup	1812	2604	2082	221	106

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-07T14:08:41Z

Builds ready [3ebad9d]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2180 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1826	2599	2168	203	97
		domContentLoaded	1761	2421	2081	159	76
		load	1825	2664	2180	210	101
		domInteractive	28	154	55	34	16
		backgroundConnect	10	458	99	94	45
		firstReactRender	18	106	47	25	12
		getState	7	200	44	41	20
		initialActions	0	1	0	0	0
		loadScripts	1333	1908	1588	140	67
		setupStore	9	58	18	15	7
		uiStartup	2028	3735	2571	398	191

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-11T19:20:56Z

Builds ready [dc9eccf]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2138 ± 257 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1732	3487	2112	459	220
		domContentLoaded	1714	3139	2032	377	181
		load	1731	3904	2138	535	257
		domInteractive	28	219	51	44	21
		backgroundConnect	12	891	115	195	94
		firstReactRender	15	274	51	73	35
		getState	6	243	49	62	30
		initialActions	0	1	0	0	0
		loadScripts	1279	2381	1544	281	135
		setupStore	7	125	27	35	17
		uiStartup	1910	6353	2644	1154	554

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

.github/workflows/identify-codeowners.yml

comments from itsyoboieltr

.github/workflows/identify-codeowners.yml

metamaskbot · 2025-03-27T19:06:54Z

Builds ready [0cb96a1]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1225 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1225	1110	1372	57	1264	1324
			load	1074	948	1235	54	1123	1235
			domContentLoaded	1067	943	1212	54	1134	997
			domInteractive	16	13	34	5	16	30
			firstPaint	758	74	1222	431	201	84
			backgroundConnect	11	6	49	8	9	10
			firstReactRender	21	15	53	7	23	41
			getState	10	4	32	7	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	811	677	946	55	860	887
			setupStore	8	4	24	3	7	9
	Webpack	Home	uiStartup	925	826	1075	57	949	966
			load	791	591	909	65	834	875
			domContentLoaded	786	586	902	65	828	867
			domInteractive	15	12	51	7	13	33
			firstPaint	434	56	905	328	823	90
			backgroundConnect	14	11	29	4	14	25
			firstReactRender	13	12	24	2	13	14
			getState	6	4	12	2	6	7
			initialActions	0	0	1	0	0	0
			loadScripts	784	576	892	65	826	857
			setupStore	7	5	15	2	8	9
Firefox	Browserify	Home	uiStartup	1373	1220	1833	139	1391	1758
			load	1231	1064	1680	136	1260	1604
			domContentLoaded	1231	1063	1680	136	1260	1604
			domInteractive	101	34	179	29	87	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	17	55	5	25	30
			firstReactRender	24	19	53	6	26	31
			getState	7	4	27	3	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1209	1045	1660	135	1241	1579
			setupStore	6	4	34	4	6	7
	Webpack	Home	uiStartup	985	828	1595	161	913	968
			load	863	729	1372	143	805	909
			domContentLoaded	863	729	1372	143	804	909
			domInteractive	114	31	371	35	150	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	102	12	21	35
			firstReactRender	19	16	26	2	20	24
			getState	9	4	55	8	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	846	718	1342	139	792	900
			setupStore	10	5	64	11	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

hmalik88 added 2 commits March 2, 2025 14:15

add codeowners announcement

9fb0bc0

dummy change

f0dad7b

metamaskbot added the team-snaps-platform Snaps Platform team label Mar 2, 2025

hmalik88 added 7 commits March 2, 2025 14:22

remove dummy comment

b6a101c

rename script

aeab6ca

script fixes

da94198

another fix

ed55915

cast type to fix type error

3454434

another fix

35639c1

update styling

1361c6a

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 2, 2025

hmalik88 added 3 commits March 2, 2025 16:12

lint fix

2a4ee37

update policy

fa353c3

Revert "update policy"

7722c34

This reverts commit fa353c3.

Update LavaMoat policies

883dc05

remove comment

ee3811e

hmalik88 marked this pull request as ready for review March 2, 2025 21:56

hmalik88 requested review from a team as code owners March 2, 2025 21:56

HowardBraham reviewed Mar 2, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

.github/workflows/identify-codeowners.yml Outdated Show resolved Hide resolved

hmalik88 added 3 commits March 2, 2025 19:51

remove script from package.json

f5e6e1b

sort owners alphabetically

7c57099

fix

1ee89c7

Merge branch 'main' into hm/add-metamaskbot-codeowner-announcement

e02a949

Merge branch 'main' into hm/add-metamaskbot-codeowner-announcement

cdad138

Merge branch 'main' into hm/add-metamaskbot-codeowner-announcement

3ebad9d

hmalik88 added team-extension-platform Extension Platform team and removed INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team labels Mar 7, 2025

hmalik88 requested a review from a team March 11, 2025 18:44

Merge branch 'main' into hm/add-metamaskbot-codeowner-announcement

dc9eccf

itsyoboieltr requested changes Mar 27, 2025

View reviewed changes

.github/workflows/identify-codeowners.yml Outdated Show resolved Hide resolved

.github/workflows/identify-codeowners.yml Outdated Show resolved Hide resolved

HowardBraham reviewed Mar 27, 2025

View reviewed changes

.github/workflows/identify-codeowners.yml Show resolved Hide resolved

hmalik88 added 3 commits March 27, 2025 13:58

Merge branch 'main' into hm/add-metamaskbot-codeowner-announcement

c7a36ca

apply code review

dc9c91a

update to use skip allow scripts

ff7ec01

MetaMask deleted a comment from HowardBraham Mar 27, 2025

itsyoboieltr approved these changes Mar 27, 2025

View reviewed changes

Merge branch 'main' into hm/add-metamaskbot-codeowner-announcement

0cb96a1

HowardBraham approved these changes Mar 27, 2025

View reviewed changes

HowardBraham enabled auto-merge March 27, 2025 18:32

HowardBraham added this pull request to the merge queue Mar 27, 2025

Merged via the queue into main with commit 23314e3 Mar 27, 2025
147 checks passed

HowardBraham deleted the hm/add-metamaskbot-codeowner-announcement branch March 27, 2025 19:40

github-actions bot locked and limited conversation to collaborators Mar 27, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add metamaskbot codeowner announcement #30668

feat: add metamaskbot codeowner announcement #30668

hmalik88 commented Mar 2, 2025 •

edited

Loading

github-actions bot commented Mar 2, 2025

hmalik88 commented Mar 2, 2025

metamaskbot commented Mar 2, 2025

metamaskbot commented Mar 2, 2025

HowardBraham left a comment

hmalik88 commented Mar 3, 2025

hmalik88 commented Mar 3, 2025 •

edited

Loading

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Mar 5, 2025

metamaskbot commented Mar 5, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 11, 2025

metamaskbot commented Mar 27, 2025

feat: add metamaskbot codeowner announcement #30668

feat: add metamaskbot codeowner announcement #30668

Conversation

hmalik88 commented Mar 2, 2025 • edited Loading

Description

Manual testing steps

Screenshots/Recordings

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 2, 2025

hmalik88 commented Mar 2, 2025

metamaskbot commented Mar 2, 2025

metamaskbot commented Mar 2, 2025

HowardBraham left a comment

Choose a reason for hiding this comment

hmalik88 commented Mar 3, 2025

hmalik88 commented Mar 3, 2025 • edited Loading

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Mar 5, 2025

metamaskbot commented Mar 5, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 11, 2025

metamaskbot commented Mar 27, 2025

hmalik88 commented Mar 2, 2025 •

edited

Loading

hmalik88 commented Mar 3, 2025 •

edited

Loading