style: Update color of values to text-default #30886

amandaye0h · 2025-03-10T16:33:15Z

Description

Updates the color of values from text-alternative to text-default. This allows users to focus on the information and improves consistency across pages.

Related issues

None

Manual testing steps

Open MetaMask
Click on NFT Details

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-10T16:33:37Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-10T17:12:15Z

Builds ready [f0f0ac6]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2110 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1857	2467	2103	152	73
		domContentLoaded	1801	2233	2037	111	53
		load	1854	2595	2110	174	83
		domInteractive	28	137	59	32	16
		backgroundConnect	10	404	69	84	40
		firstReactRender	17	110	47	27	13
		getState	8	176	33	38	18
		initialActions	0	1	0	0	0
		loadScripts	1351	1748	1550	91	44
		setupStore	9	74	21	20	10
		uiStartup	2057	3984	2489	415	199

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -8 Bytes (-0.00%)
common: 0 Bytes (0.00%)

amandaye0h · 2025-03-10T20:24:15Z

I have read the CLA Document and I hereby sign the CLA

metamaskbot · 2025-03-18T19:54:06Z

Builds ready [3863dcc]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2774 ± 1244 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	309	13147	2627	2555	1227
		domContentLoaded	1538	12171	2540	2316	1112
		load	1553	13520	2774	2591	1244
		domInteractive	27	244	60	61	29
		backgroundConnect	13	1268	241	321	154
		firstReactRender	16	241	59	58	28
		getState	5	665	102	160	77
		initialActions	0	1	0	0	0
		loadScripts	1112	10567	1924	2041	980
		setupStore	8	436	62	111	53
		uiStartup	1829	19941	3886	4100	1969

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -8 Bytes (-0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-22T16:29:48Z

Builds ready [5c47d9e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3570 ± 2243 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1536	23022	3339	4557	2188
		domContentLoaded	1477	21578	3029	4285	2057
		load	1543	23697	3570	4671	2243
		domInteractive	26	462	87	116	56
		backgroundConnect	79	2167	553	484	232
		firstReactRender	23	529	116	105	51
		getState	18	537	243	178	85
		initialActions	0	0	0	0	0
		loadScripts	1058	19889	2341	4039	1939
		setupStore	10	361	120	104	50
		uiStartup	1794	24124	6600	4965	2384

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -8 Bytes (-0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-22T18:07:56Z

Builds ready [8bfb624]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3135 ± 1262 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	542	10989	2912	2552	1226
		domContentLoaded	1478	10201	2784	2368	1137
		load	1638	11487	3135	2628	1262
		domInteractive	25	347	83	97	46
		backgroundConnect	84	1196	360	280	135
		firstReactRender	30	205	94	52	25
		getState	16	531	179	162	78
		initialActions	0	1	0	0	0
		loadScripts	1083	9177	2152	2229	1070
		setupStore	16	375	101	109	52
		uiStartup	2167	20274	5332	4446	2135

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -8 Bytes (-0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-28T20:49:29Z

Builds ready [982fa4a]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1269 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1269	1134	1567	69	1318	1364
			load	1099	970	1337	63	1147	1337
			domContentLoaded	1092	956	1319	62	1142	1319
			domInteractive	18	14	35	5	17	30
			firstPaint	751	144	1334	435	220	294
			backgroundConnect	11	7	61	6	9	10
			firstReactRender	21	13	77	8	21	36
			getState	13	5	39	8	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	864	712	1091	61	892	956
			setupStore	8	5	20	3	8	9
	Webpack	Home	uiStartup	938	813	1190	67	946	979
			load	800	608	929	59	828	876
			domContentLoaded	794	592	916	59	823	870
			domInteractive	15	12	49	7	13	34
			firstPaint	449	62	919	331	816	868
			backgroundConnect	16	10	54	8	14	39
			firstReactRender	14	12	27	3	13	25
			getState	6	3	17	2	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	792	581	906	59	821	868
			setupStore	7	5	15	2	7	9
Firefox	Browserify	Home	uiStartup	1410	1184	1964	171	1447	1819
			load	1269	1068	1814	163	1297	1657
			domContentLoaded	1269	1068	1814	163	1297	1657
			domInteractive	101	40	184	27	88	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	121	12	27	40
			firstReactRender	22	19	37	3	24	28
			getState	7	3	16	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1245	1052	1782	160	1275	1630
			setupStore	6	4	23	2	6	8
	Webpack	Home	uiStartup	980	830	1537	174	883	982
			load	863	729	1391	159	789	881
			domContentLoaded	862	729	1391	159	788	881
			domInteractive	115	40	209	25	164	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	95	11	22	36
			firstReactRender	18	16	26	2	18	22
			getState	9	4	73	11	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	846	716	1368	155	776	863
			setupStore	7	4	78	7	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: -8 Bytes (0%)
common: 0 Bytes (0%)

update color of values to text-default

f0f0ac6

amandaye0h added type-bug Something isn't working area-design Design bug (previously known as papercuts - ask Hilary for more detail) labels Mar 10, 2025

amandaye0h requested a review from sahar-fehri March 10, 2025 16:36

amandaye0h requested a review from gambinish March 10, 2025 18:00

amandaye0h added the team-assets label Mar 10, 2025

amandaye0h changed the title ~~Update color of values to text-default~~ style: update color of values to text-default Mar 10, 2025

amandaye0h changed the title ~~style: update color of values to text-default~~ style: Update color of values to text-default Mar 10, 2025

sahar-fehri previously approved these changes Mar 13, 2025

View reviewed changes

Merge branch 'main' into nft-details-color-update

3863dcc

Merge branch 'main' into nft-details-color-update

5c47d9e

Update snaps

8bfb624

amandaye0h dismissed sahar-fehri’s stale review via 8bfb624 March 22, 2025 17:32

gambinish approved these changes Mar 28, 2025

View reviewed changes

Merge branch 'main' into nft-details-color-update

982fa4a

gambinish approved these changes Mar 28, 2025

View reviewed changes

georgewrmarshall approved these changes Mar 28, 2025

View reviewed changes

georgewrmarshall added this pull request to the merge queue Mar 28, 2025

Merged via the queue into main with commit 478ec43 Mar 28, 2025
147 checks passed

georgewrmarshall deleted the nft-details-color-update branch March 28, 2025 22:34

github-actions bot locked and limited conversation to collaborators Mar 28, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

style: Update color of values to text-default #30886

style: Update color of values to text-default #30886

Uh oh!

amandaye0h commented Mar 10, 2025

Uh oh!

github-actions bot commented Mar 10, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Mar 10, 2025

Uh oh!

amandaye0h commented Mar 10, 2025

Uh oh!

metamaskbot commented Mar 18, 2025

Uh oh!

metamaskbot commented Mar 22, 2025

Uh oh!

metamaskbot commented Mar 22, 2025

Uh oh!

metamaskbot commented Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

style: Update color of values to text-default #30886

style: Update color of values to text-default #30886

Uh oh!

Conversation

amandaye0h commented Mar 10, 2025

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Mar 10, 2025

Uh oh!

amandaye0h commented Mar 10, 2025

Uh oh!

metamaskbot commented Mar 18, 2025

Uh oh!

metamaskbot commented Mar 22, 2025

Uh oh!

metamaskbot commented Mar 22, 2025

Uh oh!

metamaskbot commented Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Mar 10, 2025 •

edited

Loading