fix: Update higher-order-components callbacks per react-perf's warnings

[darkwing]

Description

Removes inline functions and objects that eslint-plugin-react-perf was flagging as bad for perf.

Related issues

Fixes:

Manual testing steps

1. Nothing should change

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [0d39f07]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (3610 ± 1490 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1777	15288	3488	3099	1488
		domContentLoaded	1703	14895	3248	3064	1471
		load	1774	15455	3610	3103	1490
		domInteractive	33	7782	486	1676	805
		backgroundConnect	70	944	385	270	130
		firstReactRender	24	198	87	50	24
		getState	16	423	149	111	53
		initialActions	0	1	0	0	0
		loadScripts	1258	13967	2581	2867	1377
		setupStore	9	336	69	73	35
		uiStartup	2082	16027	5187	3330	1599

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 607 Bytes (0.01%)
• common: 0 Bytes (0.00%)