Skip to content

Conversation

@salimtb
Copy link
Contributor

@salimtb salimtb commented Mar 24, 2025

…chitecture

Description

Open in GitHub Codespaces

Related issues

refactor the token rates controller to modular init architecture

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb marked this pull request as ready for review March 24, 2025 21:23
@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Mar 24, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [c28f96e]
Page Load Metrics (3843 ± 1965 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint150317097358839301887
domContentLoaded148415960330936791767
load150717939384340921965
domInteractive25280807536
backgroundConnect131591534481231
firstReactRender142811087938
getState41074308309148
initialActions01000
loadScripts108314765260634801671
setupStore849215615474
uiStartup170425432697361522954
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.69 KiB (0.04%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ffb713a]
Page Load Metrics (3888 ± 1596 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69114174358133391603
domContentLoaded168013373333930911484
load178214488388833241596
domInteractive26380718340
backgroundConnect1291298563325156
firstReactRender422441114019
getState4279925217885
initialActions01000
loadScripts124712047259129751428
setupStore2273015815675
uiStartup233721261734046582237
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.69 KiB (0.04%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@salimtb salimtb added this pull request to the merge queue Mar 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [c416798]
UI Startup Metrics (1217 ± 56 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1217109913845612531306
load10609531196531137985
domContentLoaded10559451189521128986
domInteractive16133341627
firstPaint7691001181412227976
backgroundConnect96283910
firstReactRender19154041928
getState11431769
initialActions001001
loadScripts83773097151870924
setupStore7515278
WebpackHomeuiStartup951770127272970984
load80559199080850920
domContentLoaded79858098281843915
domInteractive15113961432
firstPaint46760933340839890
backgroundConnect171166111549
firstReactRender1512149141324
getState7313278
initialActions001000
loadScripts79657097183842913
setupStore7517279
FirefoxBrowserifyHomeuiStartup14141210201416614681842
load12751094186516213341674
domContentLoaded12741093186516213331674
domInteractive10537204328797
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect251698112637
firstReactRender22193432328
getState7441479
initialActions001001
loadScripts12511074184116113011650
setupStore6411267
WebpackHomeuiStartup10118551523166913956
load8857431323148823952
domContentLoaded8857411323148823951
domInteractive121332042814673
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211495132332
firstReactRender19173521923
getState9461989
initialActions001001
loadScripts8677271301143812979
setupStore9460978
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.97 KiB (0.03%)
  • ui: 17 Bytes (0%)
  • common: 1 Bytes (0%)

@salimtb salimtb added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 1bef1aa Mar 31, 2025
147 checks passed
@salimtb salimtb deleted the salim/mirgrate-token-rate-to-modular-architecture branch March 31, 2025 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants