Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Mar 27, 2025

Description

Show toast message when changing gas fee tokens.

Plus:

  • Temporarily disable support for future ETH flow.
  • Add missing unit tests for GasFeeTokenIcon and GasFeeDetails.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Toast

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 requested a review from a team as a March 27, 2025 00:06
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Mar 27, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [d7ced2a]
Page Load Metrics (3638 ± 1780 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28618952329536771765
domContentLoaded165318307308935421701
load171919515363837071780
domInteractive273959411455
backgroundConnect791227556270130
firstReactRender263111195828
getState2159627215474
initialActions01000
loadScripts120517041235033901628
setupStore937716410551
uiStartup207821474682542062020

@matthewwalsh0 matthewwalsh0 force-pushed the feat/select-gas-fee-token branch 2 times, most recently from 2db9fa1 to 4e1d74d Compare March 27, 2025 12:27
Base automatically changed from feat/select-gas-fee-token to main March 27, 2025 14:02
@matthewwalsh0 matthewwalsh0 force-pushed the feat/gas-fee-token-toast branch from 0ecb743 to ffb011f Compare March 27, 2025 16:09
jpuri
jpuri previously approved these changes Mar 27, 2025
@matthewwalsh0 matthewwalsh0 requested a review from jpuri March 27, 2025 16:38
@metamaskbot
Copy link
Collaborator

Builds ready [db5444b]
UI Startup Metrics (1216 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1216109014496012461311
load10729691270561143995
domContentLoaded10679641265561138993
domInteractive17137781629
firstPaint6801321270435234277
backgroundConnect96162910
firstReactRender19154752027
getState11430768
initialActions009101
loadScripts81571899955847903
setupStore7523378
WebpackHomeuiStartup981872114659976995
load83762098370876925
domContentLoaded83160997970868919
domInteractive16127791440
firstPaint42369921337848885
backgroundConnect16124151630
firstReactRender14123231524
getState7420379
initialActions001001
loadScripts82859997770866916
setupStore8517289
FirefoxBrowserifyHomeuiStartup13281178181013413531701
load11921041165112912151553
domContentLoaded11911041165112912141552
domInteractive10147223248997
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23164962340
firstReactRender23195162434
getState8445778
initialActions002001
loadScripts11701024162612711951524
setupStore6327357
WebpackHomeuiStartup9858371509167896948
load8647301311146803936
domContentLoaded8637291310147802935
domInteractive118334654615195
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211496132336
firstReactRender19163731923
getState104761179
initialActions001001
loadScripts8467171287142785918
setupStore9565979
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 2.46 KiB (0.04%)
  • common: 75 Bytes (0%)

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Mar 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2025
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Mar 27, 2025
Merged via the queue into main with commit 428fb6f Mar 27, 2025
147 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/gas-fee-token-toast branch March 27, 2025 19:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants