- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.4k
 
feat: gas fee token toast #31338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            feat: gas fee token toast #31338
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          Builds ready [d7ced2a]
 Page Load Metrics (3638 ± 1780 ms)
  | 
    
2db9fa1    to
    4e1d74d      
    Compare
  
    Add gas fee details unit tests.
0ecb743    to
    ffb011f      
    Compare
  
    
              
                    jpuri
  
              
              previously approved these changes
              
                  
                    Mar 27, 2025 
                  
              
              
            
            
              
                    pedronfigueiredo
  
              
              approved these changes
              
                  
                    Mar 27, 2025 
                  
              
              
            
            
              
                    OGPoyraz
  
              
              approved these changes
              
                  
                    Mar 27, 2025 
                  
              
              
            
            
          Builds ready [db5444b]
 UI Startup Metrics (1216 ± 60 ms)
 Bundle size diffs [🚨 Warning! Bundle size has increased!]
  | 
    
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      Labels
      
    release-12.17.0
  Issue or pull request that will be included in release 12.17.0 
  
    team-confirmations
  Push issues to confirmations team 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Show toast message when changing gas fee tokens.
Plus:
GasFeeTokenIconandGasFeeDetails.Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist