Skip to content

Conversation

@digiwand
Copy link
Contributor

@digiwand digiwand commented Mar 27, 2025

Description

Removes .add-non-evm-account-modal__footer background-color to allow its parent background-color with border-radius applied

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

CleanShot 2025-03-27 at 17 24 13@2x

After

CleanShot 2025-03-27 at 17 25 53@2x

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner March 27, 2025 21:28
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Mar 27, 2025
@digiwand digiwand changed the title fix: missing bottom border-radius fix: missing non-evm account modal bottom border-radius Mar 27, 2025
@digiwand digiwand requested a review from gantunesr March 27, 2025 21:28
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

  • ui/components/multichain/network-list-menu/add-non-evm-account/add-non-evm-account.tsx

@digiwand digiwand added the team-core-extension-ux Core Extension UX team label Mar 27, 2025
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@digiwand digiwand added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit 9f34bfe Mar 28, 2025
147 of 148 checks passed
@digiwand digiwand deleted the fix-add-non-evm-account-missing-bottom-border-radius branch March 28, 2025 01:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 28, 2025
@digiwand digiwand added the team-new-networks PRs from the New Networks team label Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-confirmations Push issues to confirmations team team-core-extension-ux Core Extension UX team team-new-networks PRs from the New Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants