fix: flaky test Swaps - notifications tests notifications for slippage

[seaona]

Description

The problem is that we are missing the fetch trades mock, and that request is redirected to the catch-all mock returning a 200 with empty data.
Then, when the wallet tries to parse the data we get teh JSON error.

This happens ocasionally if there's "time" for that request to happen and the wallet tries to parse the JSON response, within the test run.

Circle ci error: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/134207/workflows/69597d81-ae63-41b1-b655-50d85e31b59b/jobs/4697734/tests

Related issues

Fixes:

Manual testing steps

1. Check ci run https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/134223/workflows/9c61c340-c4b3-49c8-8590-d1e2f783f124/jobs/4697845

Screenshots/Recordings

See the error fetching quotes behind the modal, which makes the test fail due to the console error.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [ccc9daf]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1218 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1218	1093	1479	61	1257	1320
			load	1059	954	1270	56	1136	986
			domContentLoaded	1054	949	1265	56	1135	989
			domInteractive	17	13	40	5	16	29
			firstPaint	750	85	1186	405	260	982
			backgroundConnect	10	6	28	3	9	10
			firstReactRender	20	15	51	7	21	36
			getState	12	4	35	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	837	736	1048	55	869	918
			setupStore	7	5	19	2	7	8
	Webpack	Home	uiStartup	978	799	1220	68	975	990
			load	838	631	937	48	858	909
			domContentLoaded	831	621	925	47	852	900
			domInteractive	16	12	46	7	14	36
			firstPaint	515	57	914	347	846	871
			backgroundConnect	16	11	42	7	15	39
			firstReactRender	14	12	33	4	14	27
			getState	7	4	16	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	829	610	915	47	850	890
			setupStore	7	5	15	2	7	9
Firefox	Browserify	Home	uiStartup	1345	1160	1853	137	1383	1669
			load	1209	1045	1704	127	1255	1492
			domContentLoaded	1208	1045	1704	127	1254	1492
			domInteractive	96	36	166	25	85	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	16	113	14	25	55
			firstReactRender	21	19	39	3	22	27
			getState	6	3	40	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1184	1028	1679	123	1223	1460
			setupStore	6	4	22	2	6	7
	Webpack	Home	uiStartup	982	837	1696	147	893	963
			load	859	728	1441	125	857	975
			domContentLoaded	858	728	1440	125	856	973
			domInteractive	114	34	200	28	155	99
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	146	17	22	32
			firstReactRender	18	16	29	2	19	22
			getState	9	4	64	9	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	842	715	1417	122	863	979
			setupStore	8	5	72	8	7	9

Bundle size diffs

• background: 0 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)

[chloeYue]

LGTM! Thanks for the fix !