Skip to content

Conversation

@seaona
Copy link
Member

@seaona seaona commented Mar 28, 2025

Description

After this PR was merged: #30709 all specs are now running in Anvil by default. In this PR I'm updating more old ganache references, to make them client agnostic.

There are no functional changes in this PR, so we can skip the quality gate

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Check ci -- everything should be working as before

Screenshots/Recordings

n/a

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Mar 28, 2025
@seaona seaona marked this pull request as ready for review March 28, 2025 09:29
@seaona seaona self-assigned this Mar 28, 2025
@seaona seaona changed the title test: rename double and triple ganache test: rename double and triple ganache references Mar 28, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [8fbe5ed]
UI Startup Metrics (1162 ± 52 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1162107213185211881265
load1015935115948963991
domContentLoaded1009931115448967997
domInteractive16133741527
firstPaint749801161387939992
backgroundConnect1167510910
firstReactRender18154031925
getState10431668
initialActions001000
loadScripts80070695950829895
setupStore7519378
WebpackHomeuiStartup965771122679960989
load82463294856848916
domContentLoaded81961393556844911
domInteractive16124871437
firstPaint48770937346832920
backgroundConnect16115481438
firstReactRender14123141425
getState7310179
initialActions001001
loadScripts81760292556842908
setupStore7515279
FirefoxBrowserifyHomeuiStartup13901201194014314251755
load12511054179213712981602
domContentLoaded12511054179113712981602
domInteractive11239199294197
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23164962433
firstReactRender23195042530
getState7444478
initialActions001001
loadScripts12301034177113712791577
setupStore6448567
WebpackHomeuiStartup9828421603179879975
load8627261392161782882
domContentLoaded8627261392161781882
domInteractive114372002415395
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect191381102130
firstReactRender18163631824
getState104811379
initialActions001001
loadScripts8457131365158771896
setupStore7521278
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -9 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@HowardBraham HowardBraham added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit cce5a8b Mar 28, 2025
147 checks passed
@HowardBraham HowardBraham deleted the rename-double-triple-ganache branch March 28, 2025 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.17.0 Issue or pull request that will be included in release 12.17.0 skip-e2e-quality-gate team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants