Skip to content

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Mar 28, 2025

Description

Fix support link in EIP-5792 cancal request modal.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4526

Manual testing steps

  1. Go to test-dapp
  2. Submit EIP-5792 send call request
  3. Press cancel button and check learn more link

Screenshots/Recordings

Screenshot 2025-03-28 at 3 27 06 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Mar 28, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri enabled auto-merge March 28, 2025 10:01
@jpuri jpuri changed the title fix: support link in EIP-5792 cancal request modal. fix: cp-12.15.0 support link in EIP-5792 cancal request modal. Mar 28, 2025
@jpuri jpuri changed the title fix: cp-12.15.0 support link in EIP-5792 cancal request modal. fix: cp-12.15.0 support link in EIP-5792 cancel request modal. Mar 28, 2025
@jpuri jpuri added this pull request to the merge queue Mar 28, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [9fad57e]
UI Startup Metrics (1188 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1188105414576512291300
load1037938127562954987
domContentLoaded1030935124961952988
domInteractive16133141627
firstPaint7391291171396251980
backgroundConnect10653699
firstReactRender20145162036
getState11433769
initialActions001001
loadScripts819708103360864928
setupStore7513278
WebpackHomeuiStartup977810128086985996
load83368694558864919
domContentLoaded82668293257858905
domInteractive16125171436
firstPaint50658918346850876
backgroundConnect16114071539
firstReactRender15123451429
getState7415278
initialActions001001
loadScripts82468192255856896
setupStore7515279
FirefoxBrowserifyHomeuiStartup13691187191414813851754
load12311053169913612611611
domContentLoaded12311053169913612601611
domInteractive9737208288598
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2516234222536
firstReactRender22194542228
getState6418278
initialActions001001
loadScripts12071035167812812371571
setupStore6447557
WebpackHomeuiStartup9698261507149878970
load8507281325133850971
domContentLoaded8507281325133850971
domInteractive117342172816296
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect191392112033
firstReactRender18162721822
getState8460878
initialActions002001
loadScripts8347141307130840960
setupStore94951178
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: -25 Bytes (0%)

Merged via the queue into main with commit 1b6bf0d Mar 28, 2025
159 checks passed
@jpuri jpuri deleted the url_fix branch March 28, 2025 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants