revert(snaps): Revert breaking changes from #31058

[GuillaumeRx]

Description

This reverts the changes made in #31058 because it breaks all the Snaps confirmations.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

• ui/pages/confirmations/components/confirm/info/__snapshots__/info.test.tsx.snap
• ui/pages/confirmations/components/confirm/info/approve/__snapshots__/approve.test.tsx.snap
• ui/pages/confirmations/components/confirm/info/personal-sign/__snapshots__/personal-sign.test.tsx.snap
• ui/pages/confirmations/components/confirm/info/personal-sign/siwe-sign/__snapshots__/siwe-sign.test.tsx.snap

💎 @MetaMask/metamask-assets

• ui/components/ui/deprecated-networks/index.scss

🔔 @MetaMask/notifications

• ui/components/multichain/notification-list-item/index.scss

🫰 @MetaMask/snaps-devs

• test/e2e/snaps/test-snap-dialog.spec.js
• ui/components/app/snaps/snap-ui-renderer/__snapshots__/snap-ui-renderer.test.js.snap
• ui/components/app/snaps/snap-ui-renderer/components/footer.ts
• ui/components/app/snaps/snap-ui-renderer/index.scss
• ui/components/app/snaps/snap-ui-renderer/snap-ui-renderer.js
• ui/components/app/snaps/update-snap-permission-list/update-snap-permission-list.js

🖥️ @MetaMask/wallet-ux

• ui/components/multichain/app-header/index.scss
• ui/components/multichain/create-named-snap-account/create-named-snap-account.tsx
• ui/components/multichain/create-named-snap-account/index.scss
• ui/components/multichain/notification-list-item/index.scss
• ui/components/multichain/pages/page/index.scss
• ui/components/multichain/pages/page/page.tsx
• ui/components/multichain/pages/permissions-page/__snapshots__/permissions-page.test.js.snap
• ui/components/multichain/pages/review-permissions-page/__snapshots__/review-permissions-page.test.tsx.snap
• ui/components/multichain/pages/send/__snapshots__/send.test.js.snap
• ui/components/multichain/pages/send/index.scss
• ui/css/itcss/components/newui-sections.scss

[metamaskbot]

Builds ready [d9f52b4]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1174 ± 55 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1174	1059	1359	55	1214	1257
			load	1024	919	1146	52	931	985
			domContentLoaded	1018	914	1142	52	930	990
			domInteractive	16	12	33	5	15	29
			firstPaint	780	80	1147	372	262	978
			backgroundConnect	11	6	147	15	8	10
			firstReactRender	20	13	44	6	19	35
			getState	11	5	27	6	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	807	702	925	52	846	891
			setupStore	7	4	16	2	7	8
	Webpack	Home	uiStartup	971	769	1490	85	981	993
			load	825	599	1188	77	860	881
			domContentLoaded	818	581	1175	77	854	877
			domInteractive	16	12	51	7	14	36
			firstPaint	555	58	1179	341	851	878
			backgroundConnect	17	11	54	9	15	41
			firstReactRender	14	12	34	3	14	24
			getState	7	4	17	2	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	816	571	1164	78	853	875
			setupStore	7	5	14	2	8	9
Firefox	Browserify	Home	uiStartup	1378	1205	1861	143	1422	1759
			load	1241	1085	1711	138	1269	1602
			domContentLoaded	1240	1084	1711	138	1268	1601
			domInteractive	101	39	225	28	89	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	66	8	27	38
			firstReactRender	22	19	33	3	23	28
			getState	7	4	26	3	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1218	1068	1678	134	1249	1573
			setupStore	6	4	34	4	5	7
	Webpack	Home	uiStartup	1003	841	1540	163	906	987
			load	878	738	1334	144	816	951
			domContentLoaded	877	738	1334	145	815	951
			domInteractive	113	35	213	26	131	73
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	98	14	24	58
			firstReactRender	19	16	27	2	19	25
			getState	8	4	60	7	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	860	723	1300	140	800	932
			setupStore	9	5	62	8	7	8

Bundle size diffs

• background: 0 Bytes (0%)
• ui: -872 Bytes (-0.01%)
• common: 0 Bytes (0%)