fix: cp-12.16.0 Follow up on the publishBatch hook

[dan437]

Description

• This PR is mainly refactoring based on the feedback in the main PR that was merged + it updates the STX controller to the latest version.

Related issues

Fixes:

Manual testing steps

1. Have STX enabled
2. Be on Ethereum mainnet
3. Go to the Send feature
4. You will be able to choose your gas token if you have enough balance for it and its a supported token

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/smart-transactions-controller@16.2.0 ➜ 16.3.0	None	0	217 kB	metamaskbot

View full report↗︎

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

• app/scripts/controller-init/confirmations/transaction-controller-init.ts

[metamaskbot]

Builds ready [a51fa31]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1194 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1194	1090	1342	56	1234	1295
			load	1039	940	1155	54	1155	987
			domContentLoaded	1033	937	1145	53	940	988
			domInteractive	16	12	30	4	16	27
			firstPaint	770	132	1152	399	224	966
			backgroundConnect	10	6	67	6	9	10
			firstReactRender	18	13	43	4	19	26
			getState	10	5	34	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	821	723	937	51	866	898
			setupStore	7	5	19	2	7	8
	Webpack	Home	uiStartup	971	785	1280	91	967	993
			load	823	635	958	69	867	922
			domContentLoaded	817	627	948	69	862	913
			domInteractive	16	12	51	8	14	38
			firstPaint	478	59	926	344	848	909
			backgroundConnect	17	11	47	8	15	41
			firstReactRender	15	12	30	4	14	28
			getState	7	4	20	2	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	815	617	938	68	861	904
			setupStore	8	5	16	2	8	9
Firefox	Browserify	Home	uiStartup	1426	1215	1961	150	1473	1784
			load	1280	1079	1804	145	1341	1630
			domContentLoaded	1280	1078	1803	145	1340	1630
			domInteractive	103	41	201	27	90	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	129	13	26	40
			firstReactRender	24	20	48	4	24	33
			getState	7	4	26	3	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1256	1056	1773	142	1312	1603
			setupStore	7	4	36	4	6	7
	Webpack	Home	uiStartup	1010	843	1618	157	910	977
			load	881	744	1367	134	841	936
			domContentLoaded	881	743	1366	134	841	936
			domInteractive	122	33	192	31	151	42
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	52	7	23	31
			firstReactRender	19	16	36	3	19	24
			getState	11	4	115	16	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	864	730	1343	130	852	992
			setupStore	11	5	61	13	7	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 372 Bytes (0.01%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)