Skip to content

Conversation

@darkwing
Copy link
Contributor

@darkwing darkwing commented Apr 11, 2025

Description

Ensures buttons are centered in full screen and the new, wider popup

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Check positioning of buttons in full screen
  2. Check positioning of buttons in popup

Screenshots/Recordings

Before

SCR-20250411-kjmt

After

SCR-20250411-kopr SCR-20250411-kooc

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Apr 11, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [d7e6143]
UI Startup Metrics (1221 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1221109713976712631331
load10669181216641173986
domContentLoaded10599111185651181983
domInteractive17136481633
firstPaint731931192423236969
backgroundConnect8435679
firstReactRender19155252030
getState13575979
initialActions001001
loadScripts82067693663869914
setupStore8526479
WebpackHomeuiStartup21021723253218222242415
load16271314207714117191875
domContentLoaded16201310207213917131852
domInteractive161172111343
firstPaint170692974720576
backgroundConnect2710286312670
firstReactRender178533751195893
getState10341679
initialActions316134
loadScripts16161309207113817071835
setupStore1962302779
FirefoxBrowserifyHomeuiStartup13221161175212313481678
load11791036162812811981533
domContentLoaded11791036162812811971532
domInteractive9937200249297
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20136382034
firstReactRender23195162229
getState7436578
initialActions001001
loadScripts11611022161312911811519
setupStore7434767
WebpackHomeuiStartup15161326190111616081726
load1296112316209813721467
domContentLoaded1295112316199913711466
domInteractive7933233247692
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2214107122233
firstReactRender34294533641
getState1052632679
initialActions002111
loadScripts1276110716069813521448
setupStore9548689

@metamaskbot
Copy link
Collaborator

Builds ready [43f1a04]
UI Startup Metrics (1225 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1225110913895512581340
load10689701215521122990
domContentLoaded10639671210521130991
domInteractive191368111745
firstPaint743851215415250972
backgroundConnect6418278
firstReactRender21175152232
getState14543978
initialActions001001
loadScripts82173095250848916
setupStore8519378
WebpackHomeuiStartup21351713247718022632368
load16361317191113717481824
domContentLoaded16291313188213617421816
domInteractive161176131351
firstPaint1856233955228339
backgroundConnect261079133057
firstReactRender215553631125794
getState12430679
initialActions317146
loadScripts16241312185913617391809
setupStore24728838277
FirefoxBrowserifyHomeuiStartup13411139173611814261570
load11991003161312212911444
domContentLoaded11991003161212212911444
domInteractive10741271418694
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect18135251928
firstReactRender22194642328
getState7449578
initialActions001001
loadScripts1183993159812312801431
setupStore6425367
WebpackHomeuiStartup14761327181511615311761
load12641133155010313111491
domContentLoaded12631133155010313111491
domInteractive7938190277085
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21147982241
firstReactRender35295963649
getState9445789
initialActions102111
loadScripts12451119153210312951477
setupStore9457778

@darkwing darkwing changed the title fix: Center buttons in wider popup fix: fix: cp-12.17.0 - Center buttons in wider popup Apr 15, 2025
@darkwing darkwing changed the title fix: fix: cp-12.17.0 - Center buttons in wider popup fix: cp-12.17.0 - Center buttons in wider popup Apr 15, 2025
@darkwing darkwing enabled auto-merge April 17, 2025 12:11
@darkwing darkwing added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 23eaea8 Apr 17, 2025
172 checks passed
@darkwing darkwing deleted the center-buttons-large branch April 17, 2025 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
@metamaskbot metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.18.0 Issue or pull request that will be included in release 12.18.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants