feat: add option to switch from standard account <-> smart account on accounts details modal #31899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux
|
|
❌ API Spec Test Failed. View the report here. |
jpuri
changed the title
…ension into acc_details_change
…ension into acc_details_change
…ension into acc_details_change
darkwing
reviewed
Apr 16, 2025
test/e2e/constants.ts
Outdated
| export const DEFAULT_FIXTURE_ACCOUNT = | ||
| '0x5CfE73b6021E818B776b421B1c4Db2474086a7e1'; | ||
|
|
||
| export const DEFAULT_FIXTURE_ACCOUNT_SHOTENED = |
There was a problem hiding this comment.
Should this be DEFAULT_FIXTURE_ACCOUNT_SHORTENED (added R)
| </Box> | ||
| <Tabs | ||
| onTabClick={() => undefined} | ||
| style={{ width: '100%', marginTop: 8 }} |
There was a problem hiding this comment.
Does this need to be 8px?
| <Preloader size={18} /> | ||
| </Box> | ||
| )} | ||
| {network7702List?.map((networkConfiguration) => ( |
There was a problem hiding this comment.
If network7702List doesn't exist or is an empty array, should we just not show this tab? Again, with your PR, I'm not seeing any items:
There was a problem hiding this comment.
Hey @darkwing : I am not sure why it is like this for you, but it's good point. @bschorchit : what should we display when there are no networks in the list.
There was a problem hiding this comment.
I agree with @darkwing 's suggestion! We can hide this tab if there are no networks in the list. Would that require a loading period though while we fetch for the networks?
There was a problem hiding this comment.
yes, it would need a loading period
There was a problem hiding this comment.
I made this change to conditionally show the tab and show spinner till we load networks supporting 7720
| expect(mockDispatch).toHaveBeenCalledTimes(1); | ||
| }); | ||
|
|
||
| it('does not renders for confirmation not coming from DAPP', () => { |
There was a problem hiding this comment.
does not render (removed s)
| const { chainId, txParams, origin } = currentConfirmation ?? {}; | ||
| const { from } = txParams; | ||
|
|
||
| if (!currentConfirmation || acknowledged || origin === 'metamask') { |
There was a problem hiding this comment.
I think we have a constant for metamask (ORIGIN_METAMASK)
| ), | ||
| )) as unknown as TransactionMeta; | ||
|
|
||
| setTransactionId(transactionMeta?.id); |
There was a problem hiding this comment.
Outside my scope of knowledge but would we want to call setTransactionId if that id is undefined?
There was a problem hiding this comment.
This fn call await dispatch(addTransactionAndRouteToConfirmationPage( generates id.
Builds ready [7be4724]
UI Startup Metrics (1262 ± 64 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…ension into acc_details_change
…ension into acc_details_change
Builds ready [5c4418a]
UI Startup Metrics (1221 ± 70 ms)
|
Builds ready [46a96df]
UI Startup Metrics (1230 ± 62 ms)
|
OGPoyraz
previously approved these changes
Apr 17, 2025
OGPoyraz
approved these changes
Apr 17, 2025
Builds ready [7ba6792]
UI Startup Metrics (1213 ± 64 ms)
|
darkwing
approved these changes
Apr 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-12.18.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add option to switch from standard account <-> smart account on accounts details modal.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4485
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist