Skip to content

Conversation

@HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Apr 11, 2025

Description

Adds a gate of do-not-exceed values on every single one of our pageload benchmarks across all configurations (chrome, firefox, browserify, webpack) for mean and p95, across all metrics. (That's 84 gates in total)

As suggested by Mark Stacey, it's a soft gate for now, that does not block the PR, but just pings HowardBraham. Once we merge to main and do more testing on this, we should make it a hard gate.

Open in GitHub Codespaces

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-tiger-deprecated DEPRECATED: team no longer exists label Apr 11, 2025
@HowardBraham HowardBraham changed the base branch from main to fix-benchmarks-and-bundle-size April 11, 2025 23:16
@HowardBraham HowardBraham added team-extension-platform Extension Platform team and removed team-tiger-deprecated DEPRECATED: team no longer exists labels Apr 11, 2025
@metamaskbot metamaskbot added the team-tiger-deprecated DEPRECATED: team no longer exists label Apr 11, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [e4dd141]
UI Startup Metrics (1206 ± 71 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1206108814077112601333
load106094112386711231166
domContentLoaded105493712346611121159
domInteractive17136681628
firstPaint77882118940810871164
backgroundConnect64212710
firstReactRender19154151936
getState1354081829
initialActions004001
loadScripts81770294361867918
setupStore74182711
WebpackHomeuiStartup21591673259018322782392
load16791296212115217492021
domContentLoaded16721292211615017411995
domInteractive171287131453
firstPaint1586435361191269
backgroundConnect281289143358
firstReactRender17455390104276352
getState154195191825
initialActions317135
loadScripts16671287211414717351965
setupStore236237352339
FirefoxBrowserifyHomeuiStartup13711186181712014411562
load12271028169512312871433
domContentLoaded12271027169512312871433
domInteractive1083929934128165
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213108132147
firstReactRender23185862232
getState83536823
initialActions001001
loadScripts12081017168112412741419
setupStore6435467
WebpackHomeuiStartup14951327181210215691685
load1289114715719213371447
domContentLoaded1288114715719213361447
domInteractive93373263396156
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2315131132340
firstReactRender34284643644
getState95396925
initialActions002111
loadScripts1268112915538913171426
setupStore85355822

cc: @HowardBraham
Benchmark value 777.7539999999987 exceeds gate value 700 for chrome browserify home mean firstPaint
Benchmark value 36 exceeds gate value 33 for chrome browserify home p95 firstReactRender
Benchmark value 174.12 exceeds gate value 165 for chrome webpack home mean firstReactRender
Benchmark value 23.04 exceeds gate value 20 for chrome webpack home mean setupStore
Benchmark value 2391.800048828125 exceeds gate value 2380 for chrome webpack home p95 uiStartup
Benchmark value 2020.5 exceeds gate value 1940 for chrome webpack home p95 load
Benchmark value 1995.0999999999767 exceeds gate value 1920 for chrome webpack home p95 domContentLoaded
Benchmark value 1965.199951171875 exceeds gate value 1890 for chrome webpack home p95 loadScripts
Benchmark value 39 exceeds gate value 35 for chrome webpack home p95 setupStore
Benchmark value 1370.87 exceeds gate value 1370 for firefox browserify home mean uiStartup
Benchmark value 107.7 exceeds gate value 105 for firefox browserify home mean domInteractive
Benchmark value 21.51 exceeds gate value 21 for firefox browserify home mean backgroundConnect
Benchmark value 165 exceeds gate value 155 for firefox browserify home p95 domInteractive
Benchmark value 47 exceeds gate value 35 for firefox browserify home p95 backgroundConnect
Benchmark value 23 exceeds gate value 15 for firefox browserify home p95 getState
Benchmark value 156 exceeds gate value 155 for firefox webpack home p95 domInteractive

@metamaskbot
Copy link
Collaborator

Builds ready [25523c1]
UI Startup Metrics (1212 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1212111815065712391305
load106395712925510901154
domContentLoaded105895212865510831146
domInteractive16134051628
firstPaint72278129142610791151
backgroundConnect6311178
firstReactRender18143231925
getState1353581927
initialActions001001
loadScripts820724104353847901
setupStore75172812
WebpackHomeuiStartup21561727258018722762417
load16811297205914517611971
domContentLoaded16741290205414417571963
domInteractive171265121451
firstPaint1616531255188283
backgroundConnect261091162758
firstReactRender16254370105282350
getState184314401433
initialActions217135
loadScripts16691287205214017561934
setupStore276359552161
FirefoxBrowserifyHomeuiStartup13981228172111514771653
load12441097159711413261476
domContentLoaded12441096159611413261476
domInteractive1024023327113142
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21135282140
firstReactRender25206072653
getState10418719821
initialActions001001
loadScripts12251081158211413061459
setupStore841801868
WebpackHomeuiStartup16091424213015616921931
load13751222187113714641638
domContentLoaded13741221187113714631638
domInteractive993722527105145
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect26168092743
firstReactRender37315254046
getState145298301030
initialActions102111
loadScripts13531204184713814421619
setupStore13630530926
cc: @HowardBraham Benchmark value 27.16 exceeds gate value 24 for chrome webpack home mean setupStore Benchmark value 2416.60009765625 exceeds gate value 2400 for chrome webpack home p95 uiStartup Benchmark value 61 exceeds gate value 40 for chrome webpack home p95 setupStore Benchmark value 1398.37 exceeds gate value 1375 for firefox browserify home mean uiStartup Benchmark value 1244.15 exceeds gate value 1230 for firefox browserify home mean load Benchmark value 1243.82 exceeds gate value 1230 for firefox browserify home mean domContentLoaded Benchmark value 10.12 exceeds gate value 9 for firefox browserify home mean getState Benchmark value 1225.39 exceeds gate value 1210 for firefox browserify home mean loadScripts Benchmark value 1653 exceeds gate value 1590 for firefox browserify home p95 uiStartup Benchmark value 1476 exceeds gate value 1470 for firefox browserify home p95 load Benchmark value 1476 exceeds gate value 1470 for firefox browserify home p95 domContentLoaded Benchmark value 53 exceeds gate value 40 for firefox browserify home p95 firstReactRender Benchmark value 1459 exceeds gate value 1450 for firefox browserify home p95 loadScripts Benchmark value 1609.08 exceeds gate value 1520 for firefox webpack home mean uiStartup Benchmark value 1374.83 exceeds gate value 1310 for firefox webpack home mean load Benchmark value 1374.42 exceeds gate value 1310 for firefox webpack home mean domContentLoaded Benchmark value 25.5 exceeds gate value 24 for firefox webpack home mean backgroundConnect Benchmark value 37.01 exceeds gate value 36 for firefox webpack home mean firstReactRender Benchmark value 14.08 exceeds gate value 11 for firefox webpack home mean getState Benchmark value 1353.48 exceeds gate value 1290 for firefox webpack home mean loadScripts Benchmark value 12.67 exceeds gate value 12 for firefox webpack home mean setupStore Benchmark value 1931 exceeds gate value 1790 for firefox webpack home p95 uiStartup Benchmark value 1638 exceeds gate value 1550 for firefox webpack home p95 load Benchmark value 1638 exceeds gate value 1550 for firefox webpack home p95 domContentLoaded Benchmark value 1619 exceeds gate value 1530 for firefox webpack home p95 loadScripts Benchmark value 26 exceeds gate value 25 for firefox webpack home p95 setupStore

@metamaskbot
Copy link
Collaborator

Builds ready [2441535]
UI Startup Metrics (1189 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1189108113716212241323
load104695512065410721173
domContentLoaded104094812015410681168
domInteractive17136081632
firstPaint63481121843110651125
backgroundConnect6428369
firstReactRender19144451926
getState1354081730
initialActions001001
loadScripts80571696353833916
setupStore75222811
WebpackHomeuiStartup21081613253616022152280
load16441246195812616921899
domContentLoaded16371242194812516881888
domInteractive171161111348
firstPaint1536233554172260
backgroundConnect319395462762
firstReactRender15950349100274338
getState153274311329
initialActions315134
loadScripts16321239191912016861859
setupStore196247242234
FirefoxBrowserifyHomeuiStartup13481195173510814001605
load12081039159811112531481
domContentLoaded12081039159811112531481
domInteractive1004124126113142
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect18124641922
firstReactRender24195572448
getState7438489
initialActions001001
loadScripts11911022157811112371467
setupStore6443467
WebpackHomeuiStartup15541366203413416341844
load13371181177712414081587
domContentLoaded13361181177612414081587
domInteractive933815818101126
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2415282272338
firstReactRender36295243846
getState94335928
initialActions002111
loadScripts13151159161411713901566
setupStore95486926

cc: @HowardBraham
Benchmark value 1481 exceeds gate value 1480 for firefox browserify home p95 load
Benchmark value 1481 exceeds gate value 1480 for firefox browserify home p95 domContentLoaded
Benchmark value 1467 exceeds gate value 1465 for firefox browserify home p95 loadScripts

@metamaskbot
Copy link
Collaborator

Builds ready [d115317]
UI Startup Metrics (1209 ± 54 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1209109813365412451308
load105995711984810851139
domContentLoaded105495311934810801132
domInteractive17136281633
firstPaint62681119942510631120
backgroundConnect6426378
firstReactRender19144241926
getState1246691828
initialActions001000
loadScripts81672494847841902
setupStore75193814
WebpackHomeuiStartup21661730258317222792420
load16981312225015817891994
domContentLoaded16881308224515217831969
domInteractive171274121455
firstPaint1626463877187274
backgroundConnect299182263460
firstReactRender17653360111300350
getState204329511535
initialActions318145
loadScripts16831307224214917791938
setupStore196293292032
FirefoxBrowserifyHomeuiStartup13281145181013613681660
load11871022167613212241493
domContentLoaded11871021167513212241493
domInteractive1023629841105191
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2013204191932
firstReactRender23195462330
getState10417623718
initialActions001001
loadScripts11691008165212912061474
setupStore5412269
WebpackHomeuiStartup15811382203412916401901
load13551174172212014321656
domContentLoaded13541173172112014321655
domInteractive984020725108152
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24167792543
firstReactRender37306354147
getState1153471031
initialActions102111
loadScripts13341153170112014081623
setupStore96497924

cc: @HowardBraham

Benchmark value 176.09 exceeds gate value 175 for chrome webpack home mean firstReactRender

Benchmark value 1682.875 exceeds gate value 1680 for chrome webpack home mean loadScripts

Benchmark value 55.40000000002328 exceeds gate value 55 for chrome webpack home p95 domInteractive

Benchmark value 1493 exceeds gate value 1485 for firefox browserify home p95 load

Benchmark value 1493 exceeds gate value 1485 for firefox browserify home p95 domContentLoaded

Benchmark value 191 exceeds gate value 166 for firefox browserify home p95 domInteractive

Benchmark value 1474 exceeds gate value 1470 for firefox browserify home p95 loadScripts

Benchmark value 1656 exceeds gate value 1640 for firefox webpack home p95 load

Benchmark value 1655 exceeds gate value 1640 for firefox webpack home p95 domContentLoaded

@metamaskbot
Copy link
Collaborator

Builds ready [b726c69]
UI Startup Metrics (1218 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1218111314736312491327
load105793312745410881145
domContentLoaded105192912665410801136
domInteractive18136581730
firstPaint737151127240910731138
backgroundConnect74293711
firstReactRender22157092245
getState1455291931
initialActions001001
loadScripts811690102454841895
setupStore85354814
WebpackHomeuiStartup21911699278819623012436
load17101313218916317862002
domContentLoaded17031309218516117791997
domInteractive171255101450
firstPaint1576734855191255
backgroundConnect339326453287
firstReactRender18154368113296338
getState164213221742
initialActions318135
loadScripts16981304218215717761967
setupStore2662204125182
FirefoxBrowserifyHomeuiStartup13371174177710514081512
load11981020162711112791394
domContentLoaded11981020162711112791394
domInteractive973517527107154
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19124761932
firstReactRender23195062246
getState7429479
initialActions001001
loadScripts11811007160811112651379
setupStore6433468
WebpackHomeuiStartup14971327192010815671691
load12921149167810013361485
domContentLoaded12921149167810013351485
domInteractive91491682098138
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22147992240
firstReactRender34284543642
getState84315822
initialActions102111
loadScripts1274113116629913171458
setupStore85385818

cc: @HowardBraham
Benchmark value 45 exceeds gate value 37 for chrome browserify home p95 firstReactRender
Benchmark value 31 exceeds gate value 30 for chrome browserify home p95 getState
Benchmark value 2190.6279956054686 exceeds gate value 2180 for chrome webpack home mean uiStartup
Benchmark value 1710.2990000000013 exceeds gate value 1700 for chrome webpack home mean load
Benchmark value 1703.3340000000067 exceeds gate value 1690 for chrome webpack home mean domContentLoaded
Benchmark value 180.97 exceeds gate value 180 for chrome webpack home mean firstReactRender
Benchmark value 1698.07298828125 exceeds gate value 1685 for chrome webpack home mean loadScripts
Benchmark value 2435.60009765625 exceeds gate value 2420 for chrome webpack home p95 uiStartup
Benchmark value 182 exceeds gate value 65 for chrome webpack home p95 setupStore

Base automatically changed from fix-benchmarks-and-bundle-size to main April 14, 2025 18:46
@metamaskbot
Copy link
Collaborator

❌ API Spec Test Failed. View the report here.

@metamaskbot
Copy link
Collaborator

Builds ready [02b69ba]
UI Startup Metrics (1203 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1203108514926212461294
load105492612715911021141
domContentLoaded104892112695910961136
domInteractive17136261630
firstPaint782140118840210811132
backgroundConnect7430379
firstReactRender21156382242
getState1353471827
initialActions001001
loadScripts812674100958853908
setupStore85213816
WebpackHomeuiStartup22971786274618124122545
load18041383235118918982176
domContentLoaded17971380234718718872153
domInteractive171366111554
firstPaint1766834862208299
backgroundConnect439334574798
firstReactRender19053379118303346
getState3143356521252
initialActions317136
loadScripts17881378234518118752122
setupStore3063575826207
FirefoxBrowserifyHomeuiStartup13601155161811114511555
load12201029147611013081424
domContentLoaded12201029147611013081424
domInteractive1003630035111163
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19134452029
firstReactRender23196062330
getState74363810
initialActions001001
loadScripts12021020146310912941408
setupStore6435368
WebpackHomeuiStartup15881373214614916521944
load13661195189314114251685
domContentLoaded13661195189214114241684
domInteractive964323224102149
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2315112132341
firstReactRender37295653946
getState94356929
initialActions102111
loadScripts13441179187113814011647
setupStore95415927

cc: @HowardBraham
Benchmark value 2296.7749877929687 exceeds gate value 2191 for chrome webpack home mean uiStartup
Benchmark value 1804.348000000001 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1796.7619999999931 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 176.03299999999524 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 42.7439990234375 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 189.6 exceeds gate value 181 for chrome webpack home mean firstReactRender
Benchmark value 30.9 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 1788.4370043945312 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 30.33 exceeds gate value 28 for chrome webpack home mean setupStore
Benchmark value 2544.5 exceeds gate value 2436 for chrome webpack home p95 uiStartup
Benchmark value 2176.4000000000233 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2152.7000000000116 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 97.800048828125 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 252 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 2121.5 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 207 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1944 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1685 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1684 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1647 exceeds gate value 1630 for firefox webpack home p95 loadScripts

@HowardBraham HowardBraham changed the title Draft ci: add a soft gate for our page load benchmarks Apr 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [1631f57]
UI Startup Metrics (1182 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1182106313305512241277
load102694311524710571107
domContentLoaded102093811454510541102
domInteractive191383121745
firstPaint784171115236610341080
backgroundConnect64202710
firstReactRender19163732027
getState13587101629
initialActions001001
loadScripts78471090944816868
setupStore74162812
WebpackHomeuiStartup22211838272316223392461
load16981390221715518131965
domContentLoaded16901382221315318091950
domInteractive161182111449
firstPaint1846560677215340
backgroundConnect3010192223465
firstReactRender23758368115341363
getState1345681728
initialActions316146
loadScripts16821377220915217971927
setupStore217292282332
FirefoxBrowserifyHomeuiStartup14231243181810414901617
load12611073165410913311461
domContentLoaded12611073165410913311461
domInteractive1033829132115148
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect241583112448
firstReactRender24205242529
getState95375923
initialActions002001
loadScripts12401050163811113151440
setupStore74406717
WebpackHomeuiStartup15491365215014015981860
load13191180192912813591630
domContentLoaded13191179192912813591629
domInteractive82333123296130
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23154662441
firstReactRender36295243845
getState1053971031
initialActions102111
loadScripts12981163190612813391608
setupStore96516928

cc: @HowardBraham
Benchmark value 45.29999999998836 exceeds gate value 35 for chrome browserify home p95 domInteractive
Benchmark value 2221.427998046875 exceeds gate value 2191 for chrome webpack home mean uiStartup
Benchmark value 183.5160000000085 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 237.24 exceeds gate value 181 for chrome webpack home mean firstReactRender
Benchmark value 2460.60009765625 exceeds gate value 2436 for chrome webpack home p95 uiStartup
Benchmark value 339.5999999999767 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 363 exceeds gate value 355 for chrome webpack home p95 firstReactRender
Benchmark value 1422.78 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1261.42 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1261.1 exceeds gate value 1230 for firefox browserify home mean domContentLoaded
Benchmark value 23.84 exceeds gate value 23 for firefox browserify home mean backgroundConnect
Benchmark value 1240.21 exceeds gate value 1230 for firefox browserify home mean loadScripts

@metamaskbot
Copy link
Collaborator

Builds ready [e4bb26b]
UI Startup Metrics (1206 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1206110313825812391317
load104393012105410801140
domContentLoaded103792612065410751134
domInteractive17135961628
firstPaint72788122540810631124
backgroundConnect74222810
firstReactRender20154152133
getState1253471527
initialActions001001
loadScripts80069295751835892
setupStore75263812
WebpackHomeuiStartup21111721258119022492413
load16071311200114617091842
domContentLoaded16001307199114317011832
domInteractive151166101339
firstPaint1696234655187271
backgroundConnect279315342476
firstReactRender21655453124340370
getState1143151223
initialActions315134
loadScripts15951306196914016991809
setupStore187243232030
FirefoxBrowserifyHomeuiStartup13641195192011114111543
load12151059176711112711402
domContentLoaded12151059176711112711402
domInteractive1104138442126182
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect201392102137
firstReactRender23195552328
getState9421821810
initialActions001001
loadScripts11961032175011312541388
setupStore6433469
WebpackHomeuiStartup15121360194010915801764
load1287114816069013361489
domContentLoaded1287114816069013361488
domInteractive80572622784127
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23158282441
firstReactRender36305553846
getState953151020
initialActions002111
loadScripts1266113215899013121466
setupStore12534634823

cc: @HowardBraham
Benchmark value 215.91 exceeds gate value 181 for chrome webpack home mean firstReactRender
Benchmark value 370 exceeds gate value 355 for chrome webpack home p95 firstReactRender

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [c9d4d65]
UI Startup Metrics (1220 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1220111314066112591337
load105495512445710921148
domContentLoaded104895112395610861142
domInteractive18136281630
firstPaint721133119441610691147
backgroundConnect6419278
firstReactRender22164672340
getState1353691831
initialActions001000
loadScripts81071899356849913
setupStore84314818
WebpackHomeuiStartup26122185317419427202980
load20681628278626421702632
domContentLoaded20571623277826221642626
domInteractive2513104152455
firstPaint2137762586253354
backgroundConnect57102976460251
firstReactRender14859366101229346
getState2952925125197
initialActions329247
loadScripts20461622271625621592588
setupStore3572565827231
FirefoxBrowserifyHomeuiStartup13271138167812013871616
load1181999155612012351484
domContentLoaded1181999155612012351484
domInteractive1004023831111155
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113111152048
firstReactRender22195552228
getState9417617814
initialActions001001
loadScripts1161984154111912221403
setupStore63374610
WebpackHomeuiStartup15391356203413916181876
load13191130178012413971587
domContentLoaded13181130178012413971587
domInteractive885832236102153
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22155672339
firstReactRender36295453848
getState95436928
initialActions102111
loadScripts12991115176412413811571
setupStore95295925

cc: @HowardBraham
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2613 exceeds gate value 2191 for chrome webpack home mean uiStartup
Benchmark value 2069 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 2058 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 25 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 213 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 57 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 2046 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 35 exceeds gate value 28 for chrome webpack home mean setupStore
Benchmark value 2981 exceeds gate value 2436 for chrome webpack home p95 uiStartup
Benchmark value 2633 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2627 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 354 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 251 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 197 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 2589 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 231 exceeds gate value 65 for chrome webpack home p95 setupStore

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [f8c3e75]
UI Startup Metrics (1224 ± 48 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1224112113744812561294
load105295011634710851142
domContentLoaded104794411584610791128
domInteractive18136471728
firstPaint649138115542010571111
backgroundConnect6411179
firstReactRender23165082244
getState1353171927
initialActions001001
loadScripts80670892045837884
setupStore85233815
WebpackHomeuiStartup21171709258119122562402
load16171313192914117241826
domContentLoaded16101309191914017211806
domInteractive151164101244
firstPaint1806443469217307
backgroundConnect25984133052
firstReactRender21555402116327362
getState143162171534
initialActions317135
loadScripts16051308189513917191782
setupStore1765182230
FirefoxBrowserifyHomeuiStartup13461159184713913971674
load1200997172114112681517
domContentLoaded1200997172114112671516
domInteractive1063933537120165
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2013117121926
firstReactRender22195342229
getState84345817
initialActions001001
loadScripts1182985170314012511500
setupStore6435367
WebpackHomeuiStartup14941357187310215561707
load1271115415688413021433
domContentLoaded1271115415688513021433
domInteractive81382843488146
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21144562339
firstReactRender35295143742
getState14429539930
initialActions102111
loadScripts1253113615488512851422
setupStore95304820

cc: @HowardBraham
Benchmark value 180 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 1674 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1517 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1516 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1500 exceeds gate value 1475 for firefox browserify home p95 loadScripts

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [7bac480]
UI Startup Metrics (1233 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1233110214886412661365
load106796812475710981166
domContentLoaded106196412435610921159
domInteractive17146361728
firstPaint75977122941510941162
backgroundConnect74243810
firstReactRender21154852232
getState1355191930
initialActions001000
loadScripts81972897655854921
setupStore84223813
WebpackHomeuiStartup21911828256516823192454
load16801403193312617851867
domContentLoaded16731399190912417781863
domInteractive161169111345
firstPaint1746654362204249
backgroundConnect289105163056
firstReactRender23458398116333363
getState14487101633
initialActions3111246
loadScripts16681397188612417741861
setupStore3172975226190
FirefoxBrowserifyHomeuiStartup14001194184711614711609
load12391068168211412971433
domContentLoaded12391068168211412971432
domInteractive1063730642123163
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2513113182370
firstReactRender24204942532
getState84334816
initialActions001001
loadScripts12161056166011312731412
setupStore63354611
WebpackHomeuiStartup14851297186311315481723
load12711124168010713071511
domContentLoaded12701124168010713071510
domInteractive79501942584139
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22144772341
firstReactRender34284743643
getState84305919
initialActions102111
loadScripts12511110163510612911492
setupStore85415820

cc: @HowardBraham
Benchmark value 1234 exceeds gate value 1230 for chrome browserify home mean uiStartup
Benchmark value 1061 exceeds gate value 1060 for chrome browserify home mean domContentLoaded
Benchmark value 1365 exceeds gate value 1360 for chrome browserify home p95 uiStartup
Benchmark value 2192 exceeds gate value 2191 for chrome webpack home mean uiStartup
Benchmark value 235 exceeds gate value 216 for chrome webpack home mean firstReactRender
Benchmark value 32 exceeds gate value 28 for chrome webpack home mean setupStore
Benchmark value 2454 exceeds gate value 2436 for chrome webpack home p95 uiStartup
Benchmark value 190 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1239 exceeds gate value 1230 for firefox browserify home mean domContentLoaded
Benchmark value 25 exceeds gate value 23 for firefox browserify home mean backgroundConnect
Benchmark value 70 exceeds gate value 48 for firefox browserify home p95 backgroundConnect

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [e1d2884]
UI Startup Metrics (1253 ± 77 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1253113616307712991367
load108097814167011161199
domContentLoaded107397314117011071192
domInteractive18146161829
firstPaint69288120142810751163
backgroundConnect84274923
firstReactRender21165262233
getState14567112034
initialActions001000
loadScripts831733114767866938
setupStore85182913
WebpackHomeuiStartup21741708265818923192431
load16751337221316217821903
domContentLoaded16681333220816017731893
domInteractive1711102141347
firstPaint1837245565212318
backgroundConnect271073143460
firstReactRender21857394116330362
getState174266271738
initialActions317146
loadScripts16631332220616117691889
setupStore227294292340
FirefoxBrowserifyHomeuiStartup14101213185211814611674
load12501083167511913151522
domContentLoaded12491083167411913151522
domInteractive1063626336119158
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313126162352
firstReactRender24195442629
getState9518418811
initialActions001001
loadScripts12281067165711712831449
setupStore74375722
WebpackHomeuiStartup15071362198511315541740
load1279115217029513221482
domContentLoaded1278115217029513221482
domInteractive80513023682132
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24144972543
firstReactRender37286164050
getState1143471031
initialActions102111
loadScripts1258113716809513011446
setupStore106568931

cc: @HowardBraham
Benchmark value 1253 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1080 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1073 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 831 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1368 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1199 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 34 exceeds gate value 31 for chrome browserify home p95 getState
Benchmark value 184 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 318 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 1410 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1250 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1250 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 1674 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1522 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1522 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of all benchmark exceeds: 184ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [293b692]
UI Startup Metrics (1230 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1230111215126712661353
load106297112875911021174
domContentLoaded105696612785910941168
domInteractive181374101630
firstPaint63291119441910561136
backgroundConnect74222712
firstReactRender24165882939
getState1354881731
initialActions001000
loadScripts815734100355841929
setupStore95314917
WebpackHomeuiStartup20791702274317121892323
load16061322216414117131792
domContentLoaded15991319214014017101785
domInteractive161168131355
firstPaint1836542267215337
backgroundConnect289369392860
firstReactRender20154377117308355
getState1234561524
initialActions612712745
loadScripts15941317211714017031783
setupStore226294412035
FirefoxBrowserifyHomeuiStartup13701213183310914151619
load12181031169911712631476
domContentLoaded12171031169911712631476
domInteractive1074122931122169
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21135582342
firstReactRender23195152433
getState73273810
initialActions001001
loadScripts11981014168311812451456
setupStore6436468
WebpackHomeuiStartup14961324175710915661707
load12841107153710113551460
domContentLoaded12831106153710113551459
domInteractive89403234599165
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21147082235
firstReactRender34284443643
getState948710830
initialActions102111
loadScripts12641092151910113401444
setupStore85445718

cc: @HowardBraham
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 183 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 337 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 165 exceeds gate value 156 for firefox webpack home p95 domInteractive
**Sum of mean exceeds: 9ms Sum of p95 exceeds: 36ms

                        Sum of all benchmark exceeds: 45ms**
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@HowardBraham HowardBraham added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 16, 2025
@metamaskbot metamaskbot added the team-tiger-deprecated DEPRECATED: team no longer exists label Apr 16, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [a0c9078]
UI Startup Metrics (1208 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1208110013815712551322
load103893611895410741131
domContentLoaded103292811825410681128
domInteractive18137591629
firstPaint654139119641110401110
backgroundConnect74223814
firstReactRender20154962031
getState1354181929
initialActions001001
loadScripts79369193052826888
setupStore85193813
WebpackHomeuiStartup20721703249115321732303
load16031329192111316841772
domContentLoaded15961325191111216771767
domInteractive161163121356
firstPaint1906240365245319
backgroundConnect23985132455
firstReactRender20854394121332366
getState124158161221
initialActions317135
loadScripts15921324188711316741765
setupStore226285381937
FirefoxBrowserifyHomeuiStartup13861140176712914661691
load12311021159113113331506
domContentLoaded12311021159113113331506
domInteractive1063630036124157
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313184222154
firstReactRender23195742430
getState9422722812
initialActions001001
loadScripts12101008157513113171493
setupStore64254610
WebpackHomeuiStartup14841305186211015561719
load1269112515879613381475
domContentLoaded1269112515869613371475
domInteractive82471582597133
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23147992341
firstReactRender35294853844
getState104438930
initialActions002111
loadScripts1250111115679513221457
setupStore85415818
cc: @HowardBraham
Benchmark value 190 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 319 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 1691 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1506 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1506 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1493 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Sum of mean exceeds: 15ms | Sum of p95 exceeds: 80ms
Sum of all benchmark exceeds: 95ms

@HowardBraham HowardBraham force-pushed the benchmark-gate branch 2 times, most recently from cf40d04 to 1d99c59 Compare April 16, 2025 23:31
@metamaskbot
Copy link
Collaborator

Builds ready [1d99c59]

itsyoboieltr
itsyoboieltr previously approved these changes Apr 17, 2025
@HowardBraham HowardBraham requested a review from micaelae April 17, 2025 16:05
@HowardBraham HowardBraham removed the team-tiger-deprecated DEPRECATED: team no longer exists label Apr 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [548f42c]

@metamaskbot
Copy link
Collaborator

Builds ready [699ac51]
UI Startup Metrics (1311 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1311118715257013491433
load111999712876311651231
domContentLoaded110996012786811581225
domInteractive221479141970
firstPaint744158124643411331202
backgroundConnect11412419822
firstReactRender241572102452
getState1354781732
initialActions001001
loadScripts849712103065902965
setupStore952231018
WebpackHomeuiStartup21021709243715822222301
load16281336185212217421784
domContentLoaded16221332184612117381781
domInteractive161160111453
firstPaint1837335261231293
backgroundConnect269286292654
firstReactRender20455378118326366
getState1143961323
initialActions317146
loadScripts16171330184212217351779
setupStore1765782033
FirefoxBrowserifyHomeuiStartup1335118616869713951532
load11881008155910412551402
domContentLoaded11871008155910412551402
domInteractive993718025112151
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113147152047
firstReactRender22195042331
getState74152810
initialActions001001
loadScripts1168994154310512361384
setupStore6419268
WebpackHomeuiStartup15341368196613116201846
load13131155177811813821564
domContentLoaded13121155177811813821563
domInteractive85532883298135
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect261580122854
firstReactRender36295043844
getState1245891031
initialActions002111
loadScripts12911139175811713631548
setupStore95345921
cc: @HowardBraham
Benchmark value 1311 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1120 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1109 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 22 exceeds gate value 20 for chrome browserify home mean domInteractive
Benchmark value 12 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 849 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1434 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1232 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1225 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 71 exceeds gate value 35 for chrome browserify home p95 domInteractive
Benchmark value 1203 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 52 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 32 exceeds gate value 31 for chrome browserify home p95 getState
Benchmark value 965 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 184 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 54 exceeds gate value 45 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 210ms | Sum of p95 exceeds: 263ms
Sum of all benchmark exceeds: 473ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 4.04 KiB (0.06%)
  • common: 0 Bytes (0%)

Copy link
Contributor

@davibroc davibroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HowardBraham HowardBraham added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@HowardBraham HowardBraham added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@HowardBraham HowardBraham added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 108289a Apr 17, 2025
169 of 170 checks passed
@HowardBraham HowardBraham deleted the benchmark-gate branch April 17, 2025 19:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants