fix: chromedriver crash on Windows

[HowardBraham]

Description

On Windows, after you run any E2E test, Google Chrome for Testing does not close, and sits open indefinitely taking CPU load (see screenshot below).

I found that if you loop through the windows/tabs and close() them before you quit() it stops this problem.

It's also possible that this is the cause of some of our cascading crash errors on CI.

For good measure, I updated selenium-webdriver.

Screenshots/Recordings

Before

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	selenium-webdriver@​4.28.1 ⏵ 4.31.0	+1			-1

View full report

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

Builds ready [c393c55]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1242 ± 55 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1242	1131	1413	55	1280	1331
			load	1075	970	1282	58	1112	1185
			domContentLoaded	1069	966	1268	57	1106	1178
			domInteractive	19	14	65	9	17	33
			firstPaint	645	132	1246	433	1070	1149
			backgroundConnect	7	4	24	3	8	15
			firstReactRender	22	16	48	6	22	34
			getState	13	5	43	8	21	27
			initialActions	0	0	1	0	0	1
			loadScripts	827	739	1010	55	859	939
			setupStore	8	4	20	3	8	15
	Webpack	Home	uiStartup	2503	1986	2978	196	2620	2791
			load	1985	1538	2499	231	2101	2439
			domContentLoaded	1971	1534	2493	226	2088	2435
			domInteractive	18	13	82	11	15	45
			firstPaint	209	91	646	70	237	324
			backgroundConnect	54	11	346	67	51	231
			firstReactRender	170	63	385	119	316	358
			getState	21	4	260	42	18	41
			initialActions	3	2	7	1	3	5
			loadScripts	1965	1532	2490	226	2084	2431
			setupStore	31	7	310	56	25	226
Firefox	Browserify	Home	uiStartup	1363	1191	1784	102	1418	1556
			load	1206	1053	1445	98	1273	1398
			domContentLoaded	1205	1053	1445	98	1273	1398
			domInteractive	103	35	356	41	116	164
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	13	205	21	21	48
			firstReactRender	23	19	53	5	24	32
			getState	9	4	176	17	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1186	1034	1428	99	1257	1366
			setupStore	8	4	164	16	6	10
	Webpack	Home	uiStartup	1473	1312	1796	109	1572	1677
			load	1264	1137	1620	99	1340	1452
			domContentLoaded	1264	1137	1620	99	1340	1452
			domInteractive	77	35	164	21	83	121
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	45	6	22	33
			firstReactRender	34	28	54	5	35	47
			getState	9	4	31	6	9	28
			initialActions	1	0	2	1	1	1
			loadScripts	1245	1119	1601	99	1318	1435
			setupStore	8	5	46	5	8	9

Bundle size diffs

• background: 0 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)

[metamaskbot]

Builds ready [fbd050a]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1237 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1237	1118	1440	71	1281	1366
			load	1068	968	1233	63	1109	1189
			domContentLoaded	1062	965	1225	62	1102	1182
			domInteractive	18	14	66	8	17	31
			firstPaint	699	76	1227	428	1080	1184
			backgroundConnect	7	4	28	3	7	10
			firstReactRender	21	16	57	6	22	30
			getState	15	5	43	10	21	33
			initialActions	0	0	1	0	0	1
			loadScripts	822	736	985	60	861	946
			setupStore	8	5	27	3	9	14
	Webpack	Home	uiStartup	2186	1780	2639	169	2304	2416
			load	1664	1357	2069	133	1761	1852
			domContentLoaded	1656	1354	2043	131	1754	1828
			domInteractive	16	11	61	11	13	46
			firstPaint	181	64	400	71	210	341
			backgroundConnect	27	10	72	14	35	58
			firstReactRender	230	57	408	119	341	364
			getState	17	4	247	33	16	33
			initialActions	3	1	7	1	4	6
			loadScripts	1651	1352	2018	131	1751	1808
			setupStore	22	7	302	33	23	42
Firefox	Browserify	Home	uiStartup	1393	1192	1710	109	1470	1639
			load	1236	1062	1550	112	1312	1486
			domContentLoaded	1236	1062	1550	112	1311	1486
			domInteractive	107	37	256	34	121	168
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	55	6	22	31
			firstReactRender	23	20	47	4	25	29
			getState	8	4	36	5	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1218	1048	1538	113	1291	1462
			setupStore	7	4	169	16	6	8
	Webpack	Home	uiStartup	1543	1349	2043	120	1627	1749
			load	1322	1162	1781	108	1403	1532
			domContentLoaded	1321	1161	1779	108	1403	1531
			domInteractive	81	55	148	21	95	126
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	82	9	22	41
			firstReactRender	36	29	58	6	38	48
			getState	9	5	38	6	9	29
			initialActions	0	0	2	1	1	1
			loadScripts	1302	1148	1762	107	1372	1509
			setupStore	8	5	50	5	8	12

Bundle size diffs

• background: 0 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)

[davidmurdoch]

works on my machine!

[metamaskbot]

Builds ready [9311b07]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1254 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1254	1125	1514	75	1294	1407
			load	1085	977	1335	72	1129	1235
			domContentLoaded	1079	972	1331	72	1121	1230
			domInteractive	18	13	62	7	17	34
			firstPaint	687	135	1252	441	1090	1205
			backgroundConnect	7	4	18	2	8	10
			firstReactRender	21	16	48	6	21	42
			getState	13	5	67	10	17	29
			initialActions	0	0	1	0	0	1
			loadScripts	838	727	1080	71	875	986
			setupStore	8	4	28	3	8	13
	Webpack	Home	uiStartup	2106	1701	2478	155	2235	2334
			load	1624	1288	2031	130	1715	1797
			domContentLoaded	1617	1282	2021	130	1708	1790
			domInteractive	16	11	103	14	13	53
			firstPaint	187	61	584	74	232	311
			backgroundConnect	28	9	241	32	28	59
			firstReactRender	211	55	418	121	332	355
			getState	11	4	32	6	14	25
			initialActions	3	1	5	1	3	5
			loadScripts	1613	1280	1999	129	1707	1786
			setupStore	19	6	281	27	20	33
Firefox	Browserify	Home	uiStartup	1334	1155	1692	108	1393	1542
			load	1189	1012	1554	112	1258	1414
			domContentLoaded	1189	1012	1554	112	1257	1414
			domInteractive	102	35	326	41	114	168
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	18	12	46	5	20	30
			firstReactRender	22	19	51	3	22	26
			getState	7	3	30	4	8	14
			initialActions	0	0	1	0	0	1
			loadScripts	1172	999	1523	111	1243	1398
			setupStore	9	4	179	24	6	15
	Webpack	Home	uiStartup	1497	1339	1853	108	1567	1695
			load	1279	1147	1589	98	1346	1491
			domContentLoaded	1279	1146	1589	98	1346	1491
			domInteractive	81	59	155	23	89	138
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	42	5	22	34
			firstReactRender	35	28	50	4	36	45
			getState	9	4	79	9	9	26
			initialActions	1	0	2	1	1	1
			loadScripts	1260	1133	1568	97	1326	1476
			setupStore	8	5	42	5	8	23

Bundle size diffs

• background: 0 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)