Skip to content

Conversation

@PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Apr 16, 2025

Description

This PR makes Solana accounts are added automatically after onboarding or importing SRP.

Related issues

Fixes:

Manual testing steps

  1. Onboard or import SRP
  2. Solana account should be added automatically with default name

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@PatrykLucka PatrykLucka self-assigned this Apr 16, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the mmi DEPRECATED: The product got sunset label Apr 16, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [31416d7]
UI Startup Metrics (1202 ± 56 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1202112713975612301312
load103894511855310671147
domContentLoaded103194111705210611139
domInteractive18136291735
firstPaint82192117936910601136
backgroundConnect73464711
firstReactRender20153642132
getState14574101632
initialActions001001
loadScripts79270592850823887
setupStore84284816
WebpackHomeuiStartup21291761252716622572350
load16371349224513417431795
domContentLoaded16311345223013317361786
domInteractive161156101348
firstPaint1736140569207319
backgroundConnect289240243056
firstReactRender21055403115312363
getState1345081528
initialActions317146
loadScripts16261344220713417311780
setupStore296308542159
FirefoxBrowserifyHomeuiStartup13791228175710714291607
load12261041163110912961442
domContentLoaded12261041163110912961442
domInteractive1073823832113177
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213136162063
firstReactRender23195342332
getState73303810
initialActions002001
loadScripts12061029161611012771393
setupStore8416416611
WebpackHomeuiStartup16531476238416916942007
load14101247215816114591765
domContentLoaded14101246215816114591765
domInteractive973930436112160
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect261799112649
firstReactRender38316154047
getState125190191031
initialActions001011
loadScripts13871228213516014311743
setupStore96313918

@PatrykLucka PatrykLucka marked this pull request as ready for review April 16, 2025 12:49
zone-live
zone-live previously approved these changes Apr 16, 2025
@kevinbluer kevinbluer force-pushed the MMMULTISRP-158-auto-create-solana-account-during-onboarding branch from d9329ea to 432411b Compare April 16, 2025 17:51
@PatrykLucka PatrykLucka force-pushed the MMMULTISRP-158-auto-create-solana-account-during-onboarding branch from 432411b to 4870254 Compare April 17, 2025 09:15
@PatrykLucka PatrykLucka changed the title feat: auto create solana account after ondboarding or srp import feat: auto create solana account after ondboarding or srp import cp-12.17.0 Apr 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4870254]
UI Startup Metrics (1202 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1202107914836312351299
load104094212925710751133
domContentLoaded103392412575710701127
domInteractive17136981627
firstPaint743137126540610521132
backgroundConnect849810710
firstReactRender21157182040
getState1253171727
initialActions001001
loadScripts795687100255827889
setupStore74132811
WebpackHomeuiStartup21581770253315322812375
load16621380193711117551822
domContentLoaded16541376192711017481802
domInteractive15115791345
firstPaint1826738462221303
backgroundConnect261074153066
firstReactRender22955401114334357
getState1344981428
initialActions3110146
loadScripts16491374190411017471800
setupStore216253252538
FirefoxBrowserifyHomeuiStartup13441182173510013931515
load12021001156710412521396
domContentLoaded12011001156710412521396
domInteractive1073924234122177
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211382112150
firstReactRender22185342229
getState7423279
initialActions001001
loadScripts1183988154910512351382
setupStore64344610
WebpackHomeuiStartup14601323184010415021655
load1251113815819312941466
domContentLoaded1251113815809312941465
domInteractive82323023684136
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21147572231
firstReactRender34285143542
getState94294921
initialActions002111
loadScripts1232112115669412771446
setupStore75223810

@metamaskbot
Copy link
Collaborator

❌ API Spec Test Failed. View the report here.

@metamaskbot
Copy link
Collaborator

Builds ready [8f31c38]
UI Startup Metrics (1215 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1215109613967012621340
load105593812086611111178
domContentLoaded104993412026511041172
domInteractive18136281728
firstPaint74080120641810721164
backgroundConnect7418279
firstReactRender21154362238
getState1253271926
initialActions003001
loadScripts81370696265867941
setupStore75172812
WebpackHomeuiStartup21871784251615923122418
load16901397188612218021874
domContentLoaded16831393187812117921865
domInteractive161262101448
firstPaint1866636965226326
backgroundConnect289235253359
firstReactRender21556378121338363
getState154221221632
initialActions319146
loadScripts16781391187612217901861
setupStore267291452239
FirefoxBrowserifyHomeuiStartup13861183167210214461625
load12341054154110712911479
domContentLoaded12341054154110712911479
domInteractive1023919429120154
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20138182136
firstReactRender23193832427
getState83334812
initialActions002001
loadScripts12151039152810812771458
setupStore64384610
WebpackHomeuiStartup15231354203913516071769
load13041156174312313781525
domContentLoaded13041156174212313771525
domInteractive86463523596144
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2415202202343
firstReactRender34294733641
getState94516922
initialActions001011
loadScripts12821137172511813591509
setupStore85284816

@PatrykLucka PatrykLucka requested a review from zone-live April 17, 2025 13:23
@PatrykLucka PatrykLucka added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 10ea293 Apr 17, 2025
170 checks passed
@PatrykLucka PatrykLucka deleted the MMMULTISRP-158-auto-create-solana-account-during-onboarding branch April 17, 2025 14:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
@metamaskbot metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

mmi DEPRECATED: The product got sunset release-12.18.0 Issue or pull request that will be included in release 12.18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants