Skip to content

Conversation

@GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Apr 16, 2025

Description

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:

  • Make comparision case sensitive in MultichainRouter
  • Add missing includeMarketData param to onAssetsConversion handler

Open in GitHub Codespaces

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Apr 16, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 16, 2025
@socket-security
Copy link

socket-security bot commented Apr 16, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​snaps-controllers@​11.2.0 ⏵ 11.2.193 +110074 +198 -1100
Updated@​metamask/​snaps-execution-environments@​7.2.0 ⏵ 7.2.194 +31007699 +1100

View full report

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/extension-platform

  • test/e2e/mock-e2e-allowlist.js

🫰 @MetaMask/snaps-devs

  • test/e2e/snaps/enums.js

@GuillaumeRx GuillaumeRx force-pushed the gr/snaps-bump-v101 branch 2 times, most recently from fcf12fd to f92cefb Compare April 16, 2025 16:36
@GuillaumeRx GuillaumeRx marked this pull request as ready for review April 17, 2025 09:26
@GuillaumeRx GuillaumeRx requested review from a team as code owners April 17, 2025 09:26
@metamaskbot
Copy link
Collaborator

Builds ready [6be0cd9]
UI Startup Metrics (1222 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1222108813776112651328
load105995411975610941158
domContentLoaded105395011915510861151
domInteractive18136391636
firstPaint746131119842010801154
backgroundConnect7419279
firstReactRender20154042132
getState1455391930
initialActions001001
loadScripts81471693954846905
setupStore85284916
WebpackHomeuiStartup21101739249915922152344
load16331343198512017461803
domContentLoaded16271339197912017371792
domInteractive16115791343
firstPaint1746359668214287
backgroundConnect241061122758
firstReactRender21055398121334357
getState1143461325
initialActions318135
loadScripts16221337195612117361790
setupStore237308402136
FirefoxBrowserifyHomeuiStartup13551155179313314151672
load12091031165013612701525
domContentLoaded12081031165013612691525
domInteractive1103736552118267
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211395112035
firstReactRender24196782448
getState9417217824
initialActions001001
loadScripts11891016157013212511512
setupStore6434367
WebpackHomeuiStartup14911330180410015471712
load1274114415068813231481
domContentLoaded1273114315058813231481
domInteractive79401421986118
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22148392341
firstReactRender35294853646
getState93305923
initialActions102111
loadScripts1255112914858713061444
setupStore11529128821

Mrtenz
Mrtenz previously approved these changes Apr 17, 2025
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Haven't tested it.

david0xd
david0xd previously approved these changes Apr 17, 2025
@GuillaumeRx GuillaumeRx enabled auto-merge April 17, 2025 10:17
MajorLift
MajorLift previously approved these changes Apr 17, 2025
@GuillaumeRx GuillaumeRx added this pull request to the merge queue Apr 17, 2025
@GuillaumeRx GuillaumeRx removed this pull request from the merge queue due to a manual request Apr 17, 2025
@GuillaumeRx GuillaumeRx dismissed stale reviews from MajorLift, david0xd, and Mrtenz via e4d83e1 April 17, 2025 12:03
@GuillaumeRx GuillaumeRx added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 17, 2025
@GuillaumeRx GuillaumeRx requested a review from DDDDDanica April 17, 2025 12:06
@GuillaumeRx GuillaumeRx requested a review from MajorLift April 17, 2025 12:06
@GuillaumeRx GuillaumeRx enabled auto-merge April 17, 2025 12:07
@GuillaumeRx GuillaumeRx added this pull request to the merge queue Apr 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [e4d83e1]
UI Startup Metrics (1194 ± 52 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1194109813415212291295
load103295211874610591107
domContentLoaded102694711824510541101
domInteractive181368101634
firstPaint69573118640410511108
backgroundConnect6419279
firstReactRender21165162133
getState13590111731
initialActions001001
loadScripts79171094146817874
setupStore85202811
WebpackHomeuiStartup21861780263715823012397
load16921367206512817901885
domContentLoaded16851364205412717801871
domInteractive161271101342
firstPaint1906738862233302
backgroundConnect25975142756
firstReactRender22656390121341361
getState143214221426
initialActions318145
loadScripts16801362205112717751870
setupStore1875482036
FirefoxBrowserifyHomeuiStartup13461176176512113961617
load11961032163812112351480
domContentLoaded11961031163812112351480
domInteractive1043726534119161
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2114109122032
firstReactRender22194632327
getState74283710
initialActions001001
loadScripts11771015161411812181437
setupStore6433469
WebpackHomeuiStartup14931338198712315671743
load12761147160610613451523
domContentLoaded12761146160510613451523
domInteractive80561552088139
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21154752231
firstReactRender35295853745
getState94315922
initialActions001011
loadScripts12571130159010513241499
setupStore10518819812

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@GuillaumeRx GuillaumeRx added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 578fd18 Apr 17, 2025
171 of 172 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/snaps-bump-v101 branch April 17, 2025 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
@metamaskbot metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 17, 2025
@DDDDDanica DDDDDanica changed the title chore(snaps): Bump Snaps packages chore(snaps): Bump Snaps packages cp-12.17.0 Apr 24, 2025
@DDDDDanica DDDDDanica added release-12.17.0 Issue or pull request that will be included in release 12.17.0 and removed release-12.18.0 Issue or pull request that will be included in release 12.18.0 INVALID-PR-TEMPLATE PR's body doesn't match template labels Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants